Repository navigation
docs(debt): note how a title uses the sceNetGetsockopt error value - #10097
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
MarcZX10
left a comment
There was a problem hiding this comment.
The shortened entry now stays within the checker’s debt-length guidance and distinguishes the call-site’s visible argument/result handling from behavior that cannot be inferred. The exact-head conventions checker and git diff --check pass; hosted eligibility, conventions and labels pass. This is documentation-only, so runtime tests do not apply; hosted product build jobs are skipped by path policy.
Please refresh this branch from current main and coordinate the debt-file order with #9523, #9542 and #9931. The exact-head sync check reports 2 ahead/111 behind, with docs/dev/debt/libSceNet.md changed on both sides since #9060. Pairwise merges of these three PR heads with this head each conflict in that file. Please agree an order with those authors, add Depends on where appropriate, and re-run the overlap/conventions checks after resolving it. I also checked the uncomparable overlap reports: #9578 merges cleanly with this head; #5836's diff is in peer-socket/setsockopt paths, but its stale pairwise merge conflicts in Export.cpp, GuestSceNet.cpp and the debt file, so please recheck that comparison after refreshing.
c4eb26b to
3b9a414
Compare
|
@MarcZX10 thanks. AI-assisted (Claude Code). |
|
@MarcZX10 thanks. The checklist reads AI-assisted (Claude Code). |
3b9a414 to
7b78542
Compare
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ength limit Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
7b78542 to
295bca0
Compare
|
Head AI-assisted (Claude Code). |
|
Refreshed with a normal merge of main (head AI-assisted (Claude Code). |
Dismissing a stale review: the requested changes were addressed after it (new head) and the merge queue blocks on it. Please request changes again if anything is still open.
What
The changed entry now reads:
Changed:
docs/dev/debt/libSceNet.md. No code change.Method: Ghidra 12.1.4 headless on the unwrapped executable of the title named; the addresses are the call sites in that executable as Ghidra maps it, read from the instruction listing (static reading only, nothing run on a console). The listing and decompiled code are game code and are not attached.
Fixes: #10096
Tested
Documentation only.
tools/check_conventions.py --base upstream/mainpasses;git merge-treeagainstmainis clean. #9523 and #9931, which edited the same file, are merged; this branch was refreshed frommainafter that. #9542, which also editeddocs/dev/debt/libSceNet.md, is merged; this branch was refreshed frommainafter that (head10624a6ad1ae9ec1efc026e4415e6d114f522f94). Every number in the sentence was recounted against the instruction listing. Not built, not run, no title run.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)AI-assisted (Claude Code).
🤖 Generated with Claude Code