Repository navigation
docs(debt): note how a title calls sceHmd2Open and sceHmd2Initialize - #10109
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
MarcZX10
left a comment
There was a problem hiding this comment.
This documentation-only change keeps the title call-site facts bounded: it says what arguments and result flow are visible, then explicitly leaves the user ID's origin and the result branch unknown. The exact-head conventions check and git diff --check pass; hosted eligibility, intake, conventions and labels pass. Runtime tests do not apply.
Please refresh from current main before merge and resolve the overlap coordination. The exact-head sync check reports 0 ahead/681 behind. A pairwise merge with #7658 conflicts in docs/dev/debt/libSceHmd2.md; the overlap report also lists #8645 as an uncomparable shared-file PR, and a pairwise merge of those heads conflicts in the Hmd2 implementation, tests and debt file. Please agree with the relevant author(s) which change lands first, declare the order in Depends on where required, refresh the debt wording against the landed/current entry, and update the checklist's current-main claim. I have not approved while the branch is this stale and the debt-file order remains unresolved.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
07dfce2 to
79b6e97
Compare
|
@MarcZX10 thanks. This PR changes one sentence in AI-assisted (Claude Code). |
MarcZX10
left a comment
There was a problem hiding this comment.
Re-reviewed exact head 79b6e976328c8b0c21f7a897774f5b36cdd4e2af. The call-site evidence remains bounded and the docs diff is clean. The earlier stale-base blocker is substantially addressed: the branch rebased onto main at e3d03fbae64e, and I verified the 147 intervening commits to current main do not touch docs/dev/debt/libSceHmd2.md; the merge preview is clean. Two integration points remain before approval: (1) #7658 and #8645 are still open and overlap this debt file; the comment says this PR need not go first but does not record an order agreed with those authors, as CONTRIBUTING requires. Please coordinate a concrete first branch and record the corresponding dependency/order in the checklist. (2) After that coordination, refresh onto current main as required by the branch guidance and rerun conventions/overlap checks. #8645 is currently DIRTY, so its eventual rebase should retain both call-site notes. No runtime test applies.
|
@MarcZX10 thanks. This PR changes one sentence in AI-assisted (Claude Code). |
|
Correction to my comments above: this PR does not change one sentence. It adds call-site sentences to two entries in AI-assisted (Claude Code). |
|
Recorded the order in the checklist and the description: AI-assisted (Claude Code). |
Dismissing a stale review: the requested changes were addressed after it (new head) and the merge queue blocks on it. Please request changes again if anything is still open.
|
Checked the two-line diff in |
What
The changed entry now reads:
Changed:
docs/dev/debt/libSceHmd2.md. No code change.Method: Ghidra 12.1.4 headless on the unwrapped executable of the title named; the addresses are the call sites in that executable as Ghidra maps it, read from the instruction listing (static reading only, nothing run on a console). The listing and decompiled code are game code and are not attached.
Fixes: #10108
Tested
Documentation only.
tools/check_conventions.py --base upstream/mainpasses;git merge-treeagainstmainis clean. Every number in the sentence was recounted against the instruction listing. Not built, not run, no title run.Overlap: #7658 (primesoul-web, DIRTY) goes first and this PR depends on it (
Depends on: #7658). #8645 (nikowolf123, DIRTY) edits the same file and also the Hmd2 implementation and tests: whichever lands second keeps both call-site notes. Pair merge preview on main 36df54b: this head x #7658 reports a conflict indocs/dev/debt/libSceHmd2.md; this head x #8645 reports conflicts indocs/dev/debt/libSceHmd2.md,core/libs/prx/libSceHmd2/Export.cpp,core/libs/prx/libSceHmd2/Hmd2.hppandcore/libs/tests/GuestHmd2.cpp; both of those PRs are themselves not mergeable into current main, so these conflicts may come from their state. This head merges cleanly into current main.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)AI-assisted (Claude Code).
🤖 Generated with Claude Code