Skip to content

fix(tests): compare the enabled exception query with the environment the host keeps #10626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oneandonlydean merged 1 commit into from
Oct 26, 2026
+2 −1
Merged

fix(tests): compare the enabled exception query with the environment the host keeps #10626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/libs/tests/GuestFloatingPoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,14 @@ void CheckEnabledExceptions() {
state.x87[1] = (state.x87[1] & ~0x3fu) | (x87 & 0x15u);
state.sse = (state.sse & ~0x7fbfu) | 0x2000 | (sse << 7) | (sse & 0x2au);
WriteEnvironment(state);
const auto written = ReadEnvironment();
*__error_nid_postfix() = 123;
const int enabled = fegetexcept_nid_postfix();
const int error = *__error_nid_postfix();
const auto after = ReadEnvironment();
WriteEnvironment(seeded);
Require(enabled == static_cast<int>(0x3f ^ x87), "enabled exceptions use the x87 masks independently of SSE");
Require(after.x87[0] == state.x87[0] && after.x87[1] == state.x87[1] && after.sse == state.sse,
Require(after.x87[0] == written.x87[0] && after.x87[1] == written.x87[1] && after.sse == written.sse,
"enabled exception query preserves control modes and flags");
Require(error == 123, "enabled exception query preserves errno");
}
Expand Down
Loading