Repository navigation
Conversation
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
I checked the exact head |
MarcZX10
left a comment
There was a problem hiding this comment.
I inspected the live overlap rather than relying only on the bot table. A two-head git merge-tree preview between this head (793a55ba18) and #11341 (fcb72551ab) conflicts in WindowsFormatting.hpp. #11341 changes FormatArguments::Next<long double> to use GuestLongDoubleLoad and removes the native-long-double layout assertions; this formatter rewrite must preserve that portable long-double path when the two changes are combined. Please coordinate the order with #11341’s author and record the dependency/order in the checklist. The #9958-first / #5021-after order is still marked pending in this draft, so keep it explicit as those authors confirm it; I am not asking anyone to close a PR.
The branch is also 1 ahead and 92 behind current main (fdb3925940), with a clean merge preview but docs/dev/debt/libc.md changed on both sides since the base. CONTRIBUTING says to keep branches current; please rebase after the stack order is settled, preserve the overlapping debt edits, and rerun the focused Windows formatters and local overlap/convention checks on that exact head. I am not approving this draft before those integration and current-head checks.
|
I have recorded the new overlap and the proposed #11341-first order. #9958's author confirmed its order and it has now merged. #9087 remains open, so I am following the requested sequence: keep this draft at |
|
#11341's author has now confirmed #11341 → #11332, and I have recorded it as agreed in the description/checklist. #9087 and #11341 are still open, so this draft remains at |
What
Windows narrow printf can misreport oversized fields or fail while formatting even a valid INT_MAX width into a tiny buffer (#11292). Check field bounds and stream padding and precision zeros while retaining the full output count. Overflow returns -1 with guest EOVERFLOW (84).
Draft for integration coordination: #9087 goes first (confirmed) and is still open. The #9958-first order was confirmed and #9958 is now merged; the follow-up must preserve its console long-double mantissa handling. #11341-first is confirmed by its author; #5021-after remains proposed, awaiting confirmation. The rebase after #9087 lands must retain deferred termination in Pad and preserve #11341's portable
GuestLongDoubleLoadpath when that stack is combined. The published head and its tests below remain unchanged while this order is coordinated.Tested
Windows 11 Home 10.0.26200, WinLibs GCC 15.2.0 UCRT r7, Ninja Release, BUILD_TESTING=ON. Head 793a55b on main 33ae5a3.
No full product suite, Linux product build, title or physical-console run. Extreme-field console error behavior remains unmeasured and is recorded in debt/libc.md.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)