Repository navigation
Conversation
Progress report (e67cc81 → 6a94996)📈 System libraries: 26.23% (+0.0022%, +1 implemented functions) ✅ 1 implemented
Changed libraries (implemented exports)
|
|
I reviewed the table and both callers against the PR description. The separate search function returns null when no entry matches, while the versioned mapper keeps its One repository rule remains: the head is based on |
MarcZX10
left a comment
There was a problem hiding this comment.
I completed the source review and the implementation matches the supplied binary analysis: _Syserror_map_search returns null for misses, while versioned _Syserror_map preserves the unknown error fallback; selected tests cover Sony codes, duplicate-code order and the unchanged unversioned map. The stated symbol NID checks with tools/nid_names.py. I found no source defect in this patch.
The remaining merge blocker is the repository branch rule: this head is based on 2db37cf1de, while current main is 035ac96edd (17 commits ahead). The intervening commits do not touch the changed implementation or test files and the merge preview is clean. Please sync to current main and rerun conventions. Eligibility, conventions, intake, labels, report, Ubuntu relinker/ASan/register-context and the Windows relinker now pass; macOS relinker, register-context and write-watch jobs remain pending. The Linux focused test result in the PR description is author-reported, not independently run here.
|
Rebased onto current |
14903c2 to
16ca7b8
Compare
|
Rechecked the fresh run 40327664941 at head |
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
I manually checked the overlap bot’s two |
|
A native Windows run of
AI-assisted: yes (Claude Code) |
16ca7b8 to
362482d
Compare
|
Rebased onto current |
362482d to
89e17c6
Compare
|
Rebased onto current |
89e17c6 to
201ad43
Compare
|
Rebased again onto current |
|
Rebased automatically onto current |
201ad43 to
94e7c49
Compare
94e7c49 to
dd732db
Compare
|
Rebased onto Local verification:
|
|
Rebased automatically onto current |
dd732db to
b44626a
Compare
|
Rebased automatically onto current |
f4a07d5 to
8262410
Compare
|
Synced to current
No source changes were needed; the patch still matches the console analysis. |
8262410 to
20a525a
Compare
|
Follow-up: |
|
Rebased automatically onto current |
1ff2ac7 to
711aaa2
Compare
|
Rebased automatically onto current |
711aaa2 to
eec100b
Compare
|
Rebased automatically onto current |
eec100b to
1f50efe
Compare
|
Rebased automatically onto current |
f444b3b to
4d4c3cd
Compare
|
Rebased automatically onto current |
|
Rebased automatically onto current |
4d4c3cd to
4791239
Compare
MarcZX10
left a comment
There was a problem hiding this comment.
The prior source review found the new versioned error-map search behavior consistent with the referenced runtime and its tests cover the Sony codes, duplicate-code ordering, and unchanged unversioned map. The author has refreshed the branch through current main and reports focused tests, conventions and diff checks passing. I did not run them locally. No new source concern is visible in this rebase.
4791239 to
9f68772
Compare
MarcZX10
left a comment
There was a problem hiding this comment.
Re-checked — looks good
I reviewed head 9f687728a12434730faa1fa95496c8f66a11a441 against recorded base 0839e8f3442331a951efe82b5ba700007bc36539; the three-file diff remains scoped to the versioned error-map export/table and focused tests. The hosted Windows product check passes and Linux was skipped; I ran no local C++ tests. I found no blocking issue.
|
Watchdog status on AI-assisted: yes |
|
Status check on exact head
Nothing to change in this branch for that failure; leaving the approved head untouched. AI-assisted: yes (Claude Code). |
|
The two and the same for Verified here at head |
|
Watchdog status on
|
|
Watchdog re-check on
|
|
Watchdog re-check on
AI-assisted: yes |
|
Watchdog re-check on
AI-assisted: yes |
|
Watchdog status on approved head
Nothing is pushed. |
9f68772 to
6a94996
Compare
What
Exports
std::__sce_v2::_Syserror_map_search(int)(a9DvgsV9dWw) and makes the versionedstd::__sce_v2::_Syserror_map(int)use the same table.The console
libc.prxin PPSA02530 and PPSA28416 exports_Syserror_map_searchat0xce8b0/0xcfb50(41 bytes). It walks 79 16-byte records, compares theintat offset 0 and returns the pointer at offset 8; the fallback is null. The record pointers are RELA relocations, so resolving them from the bundled module gives the 79 strings, including entry 0{0, "success"}and the Sony codes 107, 108, 1040, 1050, 1051 and 1074. Codes 35 and 45 occur twice and the first record wins.The versioned
_Syserror_map(4ITMYcbipA0,0xce870, 57 bytes) is the same loop with"unknown error"as the fallback. Before this change AnyPS5 used the shared FreeBSD list, which has no Sony codes and maps 95/96, which are not in the console's versioned table. Both versioned functions now share the console table; the unversioned_Syserror_mapis unchanged.Tested
Linux x86-64, GCC 16.2.1, Release,
BUILD_TESTING=ON.guest_sce_v2_exceptionsandguest_generic_categorypass.python3 tools/check_conventions.py --base origin/mainandgit diff --checkpass.sceNpGetSandboxInfobefore these imports are reached. No Windows product run; the hosted product jobs are skipped by path policy.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)