Repository navigation
docs(libSceHttp): note how two titles call sceHttpParseResponseHeader - #11531
Conversation
MarcZX10
left a comment
There was a problem hiding this comment.
The documentation adds a bounded observation about two specific caller versions: argument order/output placement and their different handling of a zero-length result. It clearly distinguishes static disassembly from console execution and limits the observation to those titles/versions. The existing function entry is preserved and the new paragraph is concise. Conventions and diff checks pass; hosted product jobs are skipped for this docs-only change.
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Manual follow-up to the overlap bot report at the current heads: #11531 changes the |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fa74e2b to
8c8a695
Compare
|
Rebased onto AI-assisted: yes (Claude Code) |
THEMANnt
left a comment
There was a problem hiding this comment.
Reviewed 8c8a695e64d93635ded73c6eae45a41c30e2a918 against author merge base b986c11a344eb094eec31cbc3977fe2ae8f6eb30 — approve the documentation change.
The parameter ordering, returned value-length handling and empty-value discussion agree with the HTTP response-header parser. This is a documentation-only clarification; the caller observations are not a new parser implementation.
Validation: checked the submitted Markdown diff, pinned implementation references and relative links; git diff --check passed. This changes documentation only. Title disassembly and console observations were not independently reproduced; no runtime regression result is claimed.
What
The
sceHttpParseResponseHeaderentry indocs/dev/debt/libSceHttp.mdtakes its signature from SharpProspero and its results from a PS5 payload. Two titles call it with that signature, and they read an empty value differently. The entry now adds:Changed:
docs/dev/debt/libSceHttp.md. No code change.Method: the addresses are virtual addresses in each title's
eboot.bin(unwrapped ELF, text at 0). Call sites were found through the import's PLT stub in therelinkeroutput (app.elf, the same text moved up by 0x400000; the bytes at each site were checked againsteboot.bin). The arguments and the branches on the result were read withobjdump. A positive result is the consumed byte count and 0 an empty value, as inGuestHttpResponseHeader.cpp. This is static reading only: nothing was run on a console. The listings are game code and are not attached.Tested
Documentation only.
tools/check_conventions.py --base upstream/mainpasses. Not built, no title run.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code