Repository navigation
feat(libSceIcu): declare 112 PS5 3.20 exports - #11760
Merged
Merged
Conversation
Remove the 36 stubs whose NIDs open PRs boykopovar#10962-boykopovar#10967, boykopovar#11115, boykopovar#11118, boykopovar#11122, boykopovar#11132 and boykopovar#11136 add to libSceIcu, leaving 112.
Progress report (b87d3d8 → f407d1b)📉 System libraries: 49.05% (-0.41%, +112 declared functions) 🆕 112 declared as stubs
Changed libraries (implemented exports)
|
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
oneandonlydean
changed the title
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declares 112 PS5 3.20
libSceIcuexports as throwing import-resolution stubs. The original declared 150; 38 are dropped in our last two commits: 2 becausemainnow defines them and 36 because open PRs #10962, #10963, #10964, #10965, #10966, #10967, #11115, #11118, #11122, #11132 and #11136 implement them in libSceIcu.Based on #9444 by @xdCloudy (closed by the author on 25 Oct).
Kept 112 exports, dropped 38 that main or an open PR already has. Every NID was recomputed with
tools/nid_names.pyfrom main. Each declaration throws throughNotImplemented_nid_no_patch; signatures and behavior are unknown and no ABI is claimed. The libSceIcu technical debt file lists each export.Tested
f407d1bd2bon main951e5963a4: fullninjaandninja libsbuild rc 0.ctest -R '^public_headers|^guest_icu': rc 0,guest_icu_version(links this library) passed, and 65 of 65public_headerstests (withpublic_headers_compile_*) passed.python3 tools/check_conventions.py --base origin/main --head HEADreports no errors.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)