Repository navigation
feat(agc): 64 KiB standard color targets - #1177
Merged
adriadam10 merged 1 commit intoOct 8, 2026
Merged
adriadam10 merged 1 commit into
adriadam10 merged 1 commit into
Conversation
This was referenced Oct 7, 2026
Color targets with the SW_64KB_S swizzle (CB_COLOR_ATTRIB3 tile mode 9) use the standard element order of the 4 KiB mode extended by the texture detiler's 64 KiB bits, and are resident like the other tiled targets. The standard blocks are now wider than tall for 2- and 8-byte elements, as the standard swizzle and the texture layout have them (they were transposed, aliasing texels). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
|
Checked the standard 4 KiB / 64 KiB element offsets and block dimensions against addrlib's 2D SW_4KB_S / SW_64KB_S for 1/2/4/8/16 B elements: all match, including the corrected block orientation. The new tests don't build without the change. Conflicted with main only in |
adriadam10
force-pushed
the
feat/standard-64k-color-targets
branch
from
October 8, 2026 08:44
4fd67e1 to
6aa8e58
Compare
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Color targets with the SW_64KB_S swizzle (CB_COLOR_ATTRIB3 tile mode 9) are rendered into, instead of refused. They use the standard element order of the 4 KiB mode extended by the texture detiler's 64 KiB bits, and are resident like the other tiled targets.
The standard blocks are now wider than tall for 2- and 8-byte elements, as the standard swizzle and the texture layout have them. They were transposed, so texels aliased each other.
tests/ColorTargetLayout.cppchecks that every element size and both standard block sizes cover their block exactly once, sized like the texture layout.Tested
Windows 11 Pro, AMD Ryzen 5 7600, NVIDIA GeForce RTX 5080 (driver 32.0.16.1074), 32 GB, MinGW-w64 GCC 15.2.0.
gta-v/testingbranch (Performance mode, the prologue).ctestpasses. Not run here: the relinker's Python tests (my local Python does not find their helper modules) andguest_gameupdate.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code