Repository navigation
docs(libSceSaveData): record the sizes titles pass to sceSaveDataCreateTransactionResource - #12020
Conversation
…teTransactionResource Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
THEMANnt
left a comment
There was a problem hiding this comment.
Reviewed ef0bfaa5f2daaa245160f14a1783ba3b82dd655f against author merge base 3ae8209b643be054ef09542f9e9e5e951b1ed73b — approve the documentation change.
The transaction-resource documentation matches synthetic positive IDs and current state validation, while keeping rollback semantics unresolved. The caller constants are not presented as proof of arbitrary console-valid flag combinations.
Validation: checked the submitted Markdown diff, pinned implementation references and relative links; git diff --check passed. This changes documentation only. Title disassembly and console observations were not independently reproduced; no runtime regression result is claimed.
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Checked the stub in |
What
The
sceSaveDataCreateTransactionResource, sceSaveDataDeleteTransactionResourceentry indocs/dev/debt/libSceSaveData.native.mdsays resource parameter validation is unknown. The stub takes auint32_t sizeand ignores it. This adds the sizes titles pass.The first argument at each
sceSaveDataCreateTransactionResourcecall site, read from the last write toedibefore the call in each relinked executable:mgs4.elfAstro Bot (PPSA21564) doesn't import it, and neither does MGS4's
app.elf. That's 15 sites: ten at 0xC0000 (768 KiB), four at 0 and one from a global. Every site the import-stub cross references list was read.How
Changed:
docs/dev/debt/libSceSaveData.native.md, one sentence added to the existing entry (now 608 characters). It still linksExport.cpp, which defines both functions. No code change.Tested
Docs only.
tools/check_conventions.py --base upstream/mainpasses andgit diff --checkis clean.tools/pr_overlap.pycouldn't compare #8285, which edits this file but already conflicts withmain. Its diff adds thesceSaveDataMount2entry and a pending-declarations entry, not this one. #8630 and #7780 also edit this file, and both merge with this branch without conflicts.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code