Repository navigation
docs(architecture): list every case that builds a draw pipeline whole - #12743
Merged
adriadam10 merged 1 commit intoOct 29, 2026
Merged
Conversation
The pipeline library paragraph listed per-face depth bias, split alternate alpha blends, rect lists, geometry shaders and a stage without a variant id as the pipelines created whole. libraryKeys in Pipeline.cpp also builds a pipeline whole for barycentrics emulated through generated tessellation stages, for tessellation on MoltenVK, for a pixel shader with a fragment shader interlock or with its LDS array in a storage buffer, and for every pipeline under APS5_PIPELINE_STATS=1, and it tests a stage's RecompileResult::Identity rather than a variant id. The paragraph now lists these cases and names libraryKeys. AI-assisted: yes
Collaborator
|
Checked each listed case against the condition in |
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs/dev/ARCHITECTURE.mdlists the draw pipelines that are created whole instead of linked from pipeline libraries: per-face depth bias, a split alpha blend into an 8_8 target with the alternate component order, rect lists, geometry shaders and "a stage without a variant id".libraryKeysincore/libs/prx/libSceAgcDriver/Graphics/src/Pipeline.cppbuilds more pipelines whole than that. Each of these cases was added after the sentence was written:BarycentricPatches);TessellationPipelineCacheUsable);FragmentInterlock);RecompileResult::functionLdsBuffer);APS5_PIPELINE_STATS=1is set (Context::pipelineExecutableInfo).The stage test is also not a "variant id" any more: it is an empty
RecompileResult::Identity. So a reader who checks, for example, a fragment shader interlock draw or a tessellated draw on MoltenVK against the doc expects pipeline libraries, but the code creates the pipeline whole.The sentence now lists every case
libraryKeysrejects and points tolibraryKeysinPipeline.cpp. Only the document changes.Tested
Arch Linux 7.2.11-zen, GCC 16.2.1, Ninja, Release, Intel Core i9-14900KF, NVIDIA GeForce RTX 4070 Ti SUPER (driver 615.78.08).
This is a documentation-only change, so nothing was built or run. I checked each listed case against the condition in
libraryKeys(Pipeline.cpp) and its helpers (BarycentricPatches,FragmentInterlock,TessellationPipelineCacheUsable, theAPS5_PIPELINE_STATSsetup inVulkanDevice.cpp,pixelFunctionLdsBufferinSpirvEmitter.cpp) on currentmain. The new relative link resolves.python3 tools/check_conventions.py --base origin/mainreports "All conventions checks passed.", andgit diff --check origin/mainis clean.tools/pr_overlap.py --branchfinds no overlap with the open pull requests it could compare. For the 11 that conflict withmainand shareARCHITECTURE.md(#5925, #6412, #6743, #7642, #7684, #9356, #9387, #9508, #10069, #10193, #11351), I checked their diffs by hand: none of them edits this sentence. #11454 shows it only as context.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)