Skip to content

feat(nppartner): add missing subscription-abort inventory export - #13038

Closed
Celegans12 wants to merge 1 commit into
boykopovar:mainfrom
Celegans12:feat/nppartner-inventory-exports-20261029
Closed

Celegans12 wants to merge 1 commit into
boykopovar:mainfrom
Celegans12:feat/nppartner-inventory-exports-20261029

Conversation

@Celegans12

@Celegans12 Celegans12 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Withdrawn after correcting the historical review gate: this exact export was closed by collaborator oneandonlydean in #5128 pending a title ID and unresolved-import log. Neither is available here. The contributor withdrawal in #9665 retracts that contributor's own hold request; it does not overturn this collaborator decision. Native inventory validation does not satisfy that condition. The topic branch is preserved and will not be reopened without the required evidence.

What

Adds the missing libSceNpPartner001 import-resolution placeholder sceNpHasEAAccessSubscriptionAbortRequest (NID pQfYTZHznMc) to the existing export source, with one reachable public declaration.

The name/NID pair comes from the 13.60 firmware export inventory, pinned to bfec40deb4c47a17d7603ee2bc79aa6862c0c56b. The name binding was independently recomputed, and the baseline source scan including explicit aliases found no existing owner of this NID. The metadata establishes a defined system-library export; it does not establish its prototype or behaviour.

Every call immediately throws through NotImplemented_nid_no_patch. The parameterless int declaration is an import placeholder, not a confirmed ABI signature. The unknown signature and behaviour are recorded in libSceNpPartner001 debt. This export adds no subscription-request cancellation or entitlement behaviour. No title compatibility is claimed.

Tested

Linux x86-64, GCC 13.3.

  • python3 tools/check_conventions.py --base origin/main: passed after committing the change.
  • python3 core/libs/tests/test_public_headers.py --audit-only: passed (373 libraries, 14,002 exports; unique reachable declarations).
  • C++20 syntax compilation of the modified export source and complete public umbrella header: passed.
  • Name/NID recomputation, global existing-owner scan and whitespace checks: passed.
  • Linux x86-64, GCC 13.3, Release, BUILD_TESTING=ON. The relevant native library and guest test target built successfully. With the three relevant libraries unmodified from main 3679074dd61aa6a899a00c19ce2e450b1cacfb60, guest_gameupdate, guest_np_partner and guest_share_play passed (3/3). Changed validation used combined commit fa466886b6ff71096d23cb08b97f44d31df36a14 (same base plus the independent one-export GameUpdate, NpPartner001 and SharePlay patches): public_headers and those three tests passed (4/4). No direct caller invocation of this unknown-ABI export was attempted.
  • The standard NID patcher succeeded with its libc preserve-export-list, and dynamic-symbol inspection confirmed the new NID in the compiled, patched library.
  • The unchanged tools/pr_overlap.py --repo boykopovar/AnyPS5 --branch feat/nppartner-inventory-exports-20261029 --jobs 8 scanned 1,442 open PRs and reported no overlap.

The full all-library build and full CTest suite were not run. No Windows, PS5 hardware, GPU, title or Ghost of Yotei validation. No tests were added solely to check symbol existence.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Fixes: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes (ChatGPT Work)

@github-actions

Copy link
Copy Markdown

Progress report (dc38224 → 36fa04c)

📉 System libraries: 44.66% (-0.01%, +1 declared functions)

🆕 1 declared as stubs
Library Name
libSceNpPartner001 sceNpHasEAAccessSubscriptionAbortRequest

Changed libraries (implemented exports)

Library Before After Change
libSceNpPartner001 3/3 (100.00%) 3/4 (75.00%) -25.00%

@Celegans12 Celegans12 closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants