Repository navigation
feat(nppartner): add missing subscription-abort inventory export - #13038
Closed
Celegans12 wants to merge 1 commit into
Closed
Celegans12 wants to merge 1 commit into
Celegans12 wants to merge 1 commit into
Conversation
Progress report (dc38224 → 36fa04c)📉 System libraries: 44.66% (-0.01%, +1 declared functions) 🆕 1 declared as stubs
Changed libraries (implemented exports)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawn after correcting the historical review gate: this exact export was closed by collaborator oneandonlydean in #5128 pending a title ID and unresolved-import log. Neither is available here. The contributor withdrawal in #9665 retracts that contributor's own hold request; it does not overturn this collaborator decision. Native inventory validation does not satisfy that condition. The topic branch is preserved and will not be reopened without the required evidence.
What
Adds the missing
libSceNpPartner001import-resolution placeholdersceNpHasEAAccessSubscriptionAbortRequest(NIDpQfYTZHznMc) to the existing export source, with one reachable public declaration.The name/NID pair comes from the 13.60 firmware export inventory, pinned to
bfec40deb4c47a17d7603ee2bc79aa6862c0c56b. The name binding was independently recomputed, and the baseline source scan including explicit aliases found no existing owner of this NID. The metadata establishes a defined system-library export; it does not establish its prototype or behaviour.Every call immediately throws through
NotImplemented_nid_no_patch. The parameterlessintdeclaration is an import placeholder, not a confirmed ABI signature. The unknown signature and behaviour are recorded inlibSceNpPartner001debt. This export adds no subscription-request cancellation or entitlement behaviour. No title compatibility is claimed.Tested
Linux x86-64, GCC 13.3.
python3 tools/check_conventions.py --base origin/main: passed after committing the change.python3 core/libs/tests/test_public_headers.py --audit-only: passed (373 libraries, 14,002 exports; unique reachable declarations).BUILD_TESTING=ON. The relevant native library and guest test target built successfully. With the three relevant libraries unmodified from main3679074dd61aa6a899a00c19ce2e450b1cacfb60,guest_gameupdate,guest_np_partnerandguest_share_playpassed (3/3). Changed validation used combined commitfa466886b6ff71096d23cb08b97f44d31df36a14(same base plus the independent one-export GameUpdate, NpPartner001 and SharePlay patches):public_headersand those three tests passed (4/4). No direct caller invocation of this unknown-ABI export was attempted.tools/pr_overlap.py --repo boykopovar/AnyPS5 --branch feat/nppartner-inventory-exports-20261029 --jobs 8scanned 1,442 open PRs and reported no overlap.The full all-library build and full CTest suite were not run. No Windows, PS5 hardware, GPU, title or Ghost of Yotei validation. No tests were added solely to check symbol existence.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)