Repository navigation
feat(libSceIcu): declare 72 callable exports - #13128
Conversation
Progress report (08a10d2 → a7e6e93)📉 System libraries: 43.05% (-0.19%, +72 declared functions) 🆕 72 declared as stubs
Changed libraries (implemented exports)
|
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
There was a problem hiding this comment.
Correction (2026-11-01): this review demanded a title for a PR where no title can supply one. CONTRIBUTING allows Unblocks: none. The technical points below are unaffected.
No title ID and no log line here. The description says "no game unblock is claimed" and Unblocks: none, so nothing shows a title on main reaching any of these 72 libSceIcu NIDs. Declaring names that throw through NotImplemented_nid_no_patch does not change what a title does today, since an unresolved import already stops it.
A related question: all 72 are int APS5_VABI name() with no parameters, including functions such as u_tolower, u_totitle and ubrk_first whose real signatures are known from ICU. If the declarations are meant to be the starting point for implementation, giving them real prototypes is cheap here and avoids redeclaring them later.
Please add the title ID that imports one of these and the log line from main showing it reaching the import. Without that this is inventory bookkeeping, not progress on a title.
What
Declare 72 additional
libSceIcucallable exports. Each candidate name hashes to a typed function NID in the public 3.20 catalogue, and per-image records show the same module and library identities in two version-labelled images. Neither image label authenticates retail firmware provenance. These are import-resolution declarations that throw; signatures and behavior are unverified, and no game unblock is claimed. Data exports and implementations are outside this change.The overlap checker could not automatically compare shared files in #12320 and #12738 because those branches conflict with main. Their added ICU definitions were checked separately; none matches the proposed NIDs.
Tested
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)