Repository navigation
Conversation
12 tasks done
Contributor
Author
|
Consolidated into #14079, which adds all of these guest_none_relocations invalid cases in one change so the test file has a single open pull request. Closing this per-case pull request in favour of that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Guest modules with more than one
PT_TLSprogram header are refused when the relinker reads the module (ElfReader::ReadProgramHeadersemitsMultiple ELF TLS segments). Theguest_none_relocationsharness did not pin that refusal. This adds one invalid-case entry that appends two emptyPT_TLSphdrs for both plain ELF and SCE-tagged fixtures.Tested
macOS arm64, upstream/main
0835ec8bdc, Python 3.13, relinker-only Release-DANYPS5_RELINKER_ONLY=ON -DBUILD_TESTING=ON:ctest -R guest_none_relocations: pass (newduplicate-tls-segmentforsce=False/True).python3 tools/check_conventions.py --base upstream/main: passed.python3 tools/pr_overlap.py --branch test/duplicate-guest-tls-segment: merge-order with test(relinker): pin invalid guest lifecycle function relocation #13711–test(relinker): pin invalid guest TLS layout in guest_none harness #13755 family on the same test file; disjoint invalid-case names.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)