Repository navigation
Conversation
Contributor
Author
|
Consolidated into #14079, which adds all of these guest_none_relocations invalid cases in one change so the test file has a single open pull request. Closing this per-case pull request in favour of that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Guest modules with a
PT_TLSprogram header whosep_memszexceeds0x7fff0000are refused on the macOS guest conversion path (GuestTlsBlockSizeinMacOsImage.cppemitsInvalid or unsupported ELF TLS layout).ElfReader::ReadProgramHeadersdoes not apply this cap, so the refusal is only observable with--macos. This adds oneinvalid_cases_macosentry withp_memsz=0x80000000, valid power-of-twop_align=8, andp_filesz=0.Tested
macOS arm64, upstream/main
0835ec8bdc, Python 3.13, relinker-only Release-DANYPS5_RELINKER_ONLY=ON -DBUILD_TESTING=ON:ctest -R guest_none_relocations: pass (newinvalid-tls-segment-large-memszforsce=False/True).ctest -j 8 -E vulkan_validation_gate: 526/526.python3 tools/check_conventions.py --base upstream/main: passed.python3 tools/pr_overlap.py --branch test/invalid-guest-tls-segment-large-memsz: merge-order only vs test(relinker): pin invalid guest lifecycle function relocation #13711–test(relinker): pin guest PT_TLS alignment cap in guest_none harness #13763 family.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)