Skip to content

test(relinker): pin invalid guest TLS large align on Windows - #13771

Closed
rooklz wants to merge 1 commit into
boykopovar:mainfrom
rooklz:test/invalid-guest-windows-tls-large-align
Closed

rooklz wants to merge 1 commit into
boykopovar:mainfrom
rooklz:test/invalid-guest-windows-tls-large-align

Conversation

@rooklz

@rooklz rooklz commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

What

  • Extend guest_none_relocations with invalid-tls-segment-large-align (PT_TLS p_align=0x4000) on --windows, pinning Invalid or unsupported ELF TLS layout from WindowsTlsBuilder (Alignment > 8192).

Tested

AI-assisted: yes
Host: macOS Homebrew toolchain; relinker build + module ctest; not exercised on a PS5 console.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attached to this PR)
  • New third-party code is built from source (n/a: none added)
  • Generic behaviour, not specific to one title
  • Depends on:
  • Fixes:
  • Unblocks:
  • GPUs tested: n/a
  • AI-assisted: yes

@oneandonlydean

Copy link
Copy Markdown
Collaborator

@rooklz The test code passes at 3f898b7abe. Please update the PR description to the required ### What, ### Tested and ### Checklist sections and fill the template checklist fields. The current ## Summary / ## Test plan body produces three pr-template errors when checked with the repository checker. A local --base check alone does not validate the remote PR body; pass the description using --body or use the PR event check.

When folding with #13767, please retain both Windows invalid cases in one invalid_cases_windows generator and keep one Windows test loop, plus both distinct fixture helpers.

@rooklz

rooklz commented Oct 31, 2026

Copy link
Copy Markdown
Contributor Author

Consolidated into #14079, which adds all of these guest_none_relocations invalid cases in one change so the test file has a single open pull request. Closing this per-case pull request in favour of that one.

@rooklz rooklz closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants