Skip to content

test(tools): decode check_test_registration CLI output as UTF-8 #13839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oneandonlydean merged 1 commit into from
Nov 1, 2026
Merged

test(tools): decode check_test_registration CLI output as UTF-8 #13839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/tests/test_test_registration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ def test_unknown_windows_ninja_encoding_is_rejected(self):

def run_tool(self, build):
return subprocess.run([sys.executable, "-I", str(Path(check_test_registration.__file__)), str(build)],
capture_output=True, text=True, timeout=30)
capture_output=True, encoding="utf-8", timeout=30)

def test_missing_build_directory_is_reported_without_a_traceback(self):
with tempfile.TemporaryDirectory() as directory:
Expand Down
Loading