Skip to content

fix(ci): fail the stale label cleanup when listing the labelled pull requests fails #14191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oneandonlydean merged 2 commits into from
Nov 2, 2026
Merged

fix(ci): fail the stale label cleanup when listing the labelled pull requests fails #14191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c407ae1
fix(ci): fail the stale label cleanup when listing the labelled pull …
MarcZX10 Oct 31, 2026
e09eb54
test(ci): require the stale label cleanup step to run with pipefail
MarcZX10 Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/stale-conflicts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
steps:
- env:
GH_TOKEN: ${{ github.token }}
shell: bash
run: |
gh pr list -R "$GITHUB_REPOSITORY" --label stale -L 1000 --json number,labels \
--jq '.[] | select(all(.labels[]; .name != "needs rebase")) | .number' |
Expand Down
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,8 @@ if(BUILD_TESTING)
add_test(NAME pad_input COMMAND ${Python3_EXECUTABLE}
${CMAKE_CURRENT_SOURCE_DIR}/tools/tests/test_pad_input.py)
set_tests_properties(pad_input PROPERTIES TIMEOUT 20)
add_test(NAME stale_conflicts_workflow COMMAND ${Python3_EXECUTABLE}
${CMAKE_CURRENT_SOURCE_DIR}/tools/tests/test_stale_conflicts_workflow.py)
add_test(NAME pad_timeline COMMAND ${Python3_EXECUTABLE}
${CMAKE_CURRENT_SOURCE_DIR}/tools/tests/test_pad_timeline.py)
set_tests_properties(pad_timeline PROPERTIES TIMEOUT 20)
Expand Down
16 changes: 16 additions & 0 deletions tools/tests/test_stale_conflicts_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import unittest
from pathlib import Path

WORKFLOW = Path(__file__).resolve().parents[2] / ".github/workflows/stale-conflicts.yml"


class StaleLabelStepTests(unittest.TestCase):
def test_label_cleanup_step_runs_with_pipefail(self):
text = WORKFLOW.read_text(encoding="utf-8")
step = text.split(" - env:", 1)[1].split(" - uses:", 1)[0]
self.assertIn("gh pr list", step)
self.assertIn("shell: bash", step)


if __name__ == "__main__":
unittest.main()
Loading