Repository navigation
docs(debt): name what KytyPS5 does for sceAmprMeasureCommandSizeReadFile - #14471
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
✅ AMD GPU test: passedPR head
Unstable on main (1, these also failed in recent main runs on this machine; not counted against this PR)Failing on main too (3, not counted against this PR)Validation IDs already present on main (4 IDs in 347 tests)Skipped (2)ReproduceAutomated build and test on a contributor's AMD machine; it does not replace upstream CI. A new comment is posted for each new push. Full logs. |
MarcZX10
left a comment
There was a problem hiding this comment.
Reviewed — no blocking findings
Documentation only: one debt line about sceAmprMeasureCommandSizeReadFile. The line says the export takes no argument and returns the size of the host command record every time. The base implementation does exactly that (libSceAmpr/Export.cpp lines 663-665, return sizeof(Apr::ReadFileCommand)). The rest of the line describes another emulator's code, which I did not check.
What I ran
- Head
e30c19a60255f096da2f110bfe4db19c7903e295; basee450145140...(the base moved; the diff is against the PR's own base). 1 file, +1/-0:docs/dev/debt/libSceAmpr.md. - Read the debt line and the base implementation of
sceAmprMeasureCommandSizeReadFile. - Read-only checks from the trusted main checkout (precheck not run: no PR-head code is run here): diff check and conventions passed.
- Hosted: no CTest relevance for a documentation change.
- No MarcZX10 review at this head.
Results
| Check | Result | Note |
|---|---|---|
| Diff check | passed | |
| Conventions and PR template | passed | conventions check from the main checkout |
| Mergeability and dependencies | passed | depends on none; the stack check passed |
| Export description matches the base code | passed | takes no argument; returns sizeof(Apr::ReadFileCommand) |
| Claims about another emulator's code | not verified | external repository, not checked |
| Build and runtime tests | not run | documentation only |
| Negative controls | not run | not applicable |
| Hosted CI | passed | windows passed; linux and relinkers skipped |
Read-only check output
Precheck was not run: no PR-head code is run here. Conventions: passed. Hosted: gh api repos/boykopovar/AnyPS5/commits/e30c19a60255f096da2f110bfe4db19c7903e295/check-runs.
Negative control
Not applicable: documentation only.
Findings
Blocking
None.
Non-blocking
None.
Sources
- Debt line: https://github.com/boykopovar/AnyPS5/blob/e30c19a60255f096da2f110bfe4db19c7903e295/docs/dev/debt/libSceAmpr.md
- Implementation:
AnyPS5/core/libs/prx/libSceAmpr/Export.cpp
Lines 663 to 665 in f2d874c
Not verified
- The emulator comparison in the debt line (an external repository and commit) was not checked.
To get this to a good state
- Nothing to change.
What
Adds one entry to the libSceAmpr technical debt:
sceAmprMeasureCommandSizeReadFiletakes no argument and returns the size of the host command record every time, so it never fails, and the commit that added it names no measurement. KytyPS5 (PS5), the only one of the three emulators with libSceAmpr (shadPS4 and fpPS4 only list the names), takes four arguments and returnsKERNEL_ERROR_EINVALwhen the destination range or the file offset is out of range, and otherwise 0x14, or 0x18 when the offset needs more than 32 bits. The entry says only what KytyPS5 does and what this library does; it does not say which signature is right, and no code or test changes.Tested
Documentation only.
tools/check_conventions.py --base upstream/mainpasses. Based onmainf1a7b02028, and it merges withmaine450145140without a conflict (checked 2026-11-01 at 14:51 UTC). I readsceAmprMeasureCommandSizeReadFileand its range and offset checks in KytyPS5src/libs/libAmpr.cppat commit 5e837a9beac82c031868eaad9348d6a48245fb99, searched shadPS4 and fpPS4 forAmprMeasure(shadPS4 has it only in its name table, fpPS4 only in name lists), and read our function inExport.cppand its call inGuestAmpr.cpp. Not run: a build or a test, because nothing but the debt file changes.Overlap
Checked on 2026-11-01 against
mainf1a7b02028ae50adaf6c5aaaef892a51841b25bf(1669 open pull requests, listed at 13:30 UTC; the merge checks ran from 13:30 UTC to 13:43 UTC). I took the changed files of each fromgit diff --name-onlyagainst its merge base. Seven of them change libSceAmpr files orGuestAmpr.cpp: #14212, #13990, #13730, #12581, #10025, #7648 and #7081. Only #14212 changesdocs/dev/debt/libSceAmpr.md, and it conflicts with this head but also conflicts withmainon its own, so not because of this entry; #10025 and #7081 conflict withmainon their own too, and #13990, #13730, #12581 and #7648 merge cleanly with this head. None of the seven has a changed line that namessceAmprMeasureCommandSizeReadFile. None of the 34 pull requests opened since (#14431 to #14469, listed at 14:51 UTC) changes a libSceAmpr file.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)AI-assisted (Claude Code).
🤖 Generated with Claude Code