Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MarcZX10
left a comment
MarcZX10
left a comment
There was a problem hiding this comment.
Reviewed — no blocking findings
The added debt sentence matches the current NGS2 rejection condition; the title-specific runtime observation is author-reported.
What I ran
Reviewed PR #15341 at head 5471193afa3dfa82eb1589a21e347052fc6c4b09, based on 7feb37ee3e30e10139b483fb4df689d5b5b69ab8. The change is one sentence in an existing debt entry. The stack checker reports a clean merge. Environment: Debian Linux x86_64, Python 3.11.2, GCC 12.2.0. This documentation-only change does not need a build or CTest.
git diff --check 7feb37ee3e30e10139b483fb4df689d5b5b69ab8...5471193afa3dfa82eb1589a21e347052fc6c4b09
python3 tools/pr_precheck.py --repo boykopovar/AnyPS5 --pr 15341
python3 tools/pr_overlap.py --branch refs/review/pr-15341-20261103 --repo boykopovar/AnyPS5
gh pr checks 15341 --repo boykopovar/AnyPS5
git show refs/review/pr-15341-20261103:core/libs/prx/libSceNgs2.native/src/Voice.cpp | nl -ba | sed -n '748,767p'
git show refs/review/pr-15341-20261103:docs/dev/debt/libSceNgs2.native.md | nl -ba | sed -n '77,78p'
gh pr list --repo boykopovar/AnyPS5 --state open --search 'path:docs/dev/debt/libSceNgs2.native.md' --limit 100 --json number,title,headRefOid --jq '.[] | [.number,.headRefOid,.title] | @tsv'Results
| Check | Result | Note |
|---|---|---|
| Diff and conventions | passed | Patch and required PR fields pass. |
| Source-to-debt consistency | passed | PatchDest throws for input 1 when the destination is not a custom submixer with enough inputs. |
| Current-main merge preview | passed | Exact head merges cleanly. |
| Overlap helper | failed | It could not parse its GitHub response; the path search returned no rows. |
| Precheck heuristics | failed | The isolated snapshot lacks the optional test-quality helper; no source/test check applies to this docs-only change. |
| Hosted policy checks | not run | All four checks were queued at refresh. |
Precheck table and raw output
Precheck table, copied from its report:
| Check | Status | Command / reason |
|---|---|---|
| build_and_compile | not_applicable | The precheck deliberately does not configure, build, or compile AnyPS5. |
| diff_check | passed | git diff --check 7feb37ee3e30e10139b483fb4df689d5b5b69ab8...5471193afa3dfa82eb1589a21e347052fc6c4b09 |
| conventions_and_pr_template | passed | /usr/bin/python3 tools/check_conventions.py --base 7feb37ee3e30e10139b483fb4df689d5b5b69ab8 --head 5471193afa3dfa82eb1589a21e347052fc6c4b09 --title docs(debt): name the title that patches to input 1 of an NGS2 voice --body /tmp/anyps5-pr-precheck/boykopovar-AnyPS5-pr-15341-5471193afa3d/pr-body.md |
| changed_export_abi_audit | not_applicable | No changed source or public header under core/libs/prx. |
| python_syntax | not_applicable | No changed Python implementation files. |
| related_python_unit_tests | not_applicable | No changed tools/ module has an existing sibling tools/tests/test_<module>.py suite. |
| python_test_registration | not_applicable | No changed test_*.py files. |
| live_dependency_and_mergeability_check | passed | /usr/bin/python3 /marc/AnyPS5/tools/pr_stack_check.py 15341 --repo boykopovar/AnyPS5 --output-dir /tmp/anyps5-pr-precheck/boykopovar-AnyPS5-pr-15341-5471193afa3d/stack |
| build_dependent_cpp_tests | not_applicable | No C/C++ implementation or test files changed. |
| test_quality_heuristics | failed | /usr/bin/python3 /tmp/anyps5-pr-precheck/boykopovar-AnyPS5-pr-15341-5471193afa3d/head-5471193afa3d-8ad91d7b/tools/pr_test_quality.py --root /tmp/anyps5-pr-precheck/boykopovar-AnyPS5-pr-15341-5471193afa3d/head-5471193afa3d-8ad91d7b --json docs/dev/debt/libSceNgs2.native.md |
| negative_controls | not_applicable | No changed Python test module in tools/ can be run as a no-build base-source control. |
All conventions checks passed.
pr_overlap: Invalid \uXXXX escape: line 1 column 1827862 (char 1827861)
/usr/bin/python3: can't open file '/tmp/anyps5-pr-precheck/boykopovar-AnyPS5-pr-15341-5471193afa3d/head-5471193afa3d-8ad91d7b/tools/pr_test_quality.py': [Errno 2] No such file or directory
Hosted CI status at final refresh
conventions pending 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556939310/job/125658007310
eligibility pending 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556940511/job/125658009843
intake pending 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556939125/job/125658006768
labels pending 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556939091/job/125658006720
Negative control
Not applicable: this PR changes documentation only, so there is no test assertion or code path to mutate.
Findings
Blocking
None found in the one-line documentation change.
Non-blocking
The reported PPSA35169 startup failure was not independently reproduced during this review; the PR body gives the title, tested commit, hardware, and observed timing.
Sources
- Input validation and throw condition at the reviewed head
- Updated NGS2 debt entry at the reviewed head
Not verified
I did not run PPSA35169, inspect its executable, or independently confirm the reported NVIDIA RTX 4080 SUPER run. Hosted conventions, eligibility, intake, and labels checks were queued at final refresh. The overlap helper failed; a path query is not a complete overlap audit.
To get this to a good state
No source or documentation change is requested. Let the hosted checks finish; I will recheck this exact head and their results before deciding whether to approve.
MarcZX10
left a comment
MarcZX10
left a comment
There was a problem hiding this comment.
Re-checked — same head, approved
The reviewed one-line debt update is unchanged at head 5471193afa3dfa82eb1589a21e347052fc6c4b09; source inspection supports the guard description, and all applicable hosted policy checks now pass.
What I ran
Confirmed the PR remains open at the exact reviewed head, based on 7feb37ee3e30e10139b483fb4df689d5b5b69ab8. The documentation change previews cleanly against current main. Environment: Debian Linux x86_64, Python 3.11.2, Git 2.39.5. No build or CTest was run because this PR changes documentation only.
git diff --check 7feb37ee3e30e10139b483fb4df689d5b5b69ab8...5471193afa3dfa82eb1589a21e347052fc6c4b09
python3 tools/check_conventions.py --base 7feb37ee3e30e10139b483fb4df689d5b5b69ab8 --head 5471193afa3dfa82eb1589a21e347052fc6c4b09 --title 'docs(debt): name the title that patches to input 1 of an NGS2 voice' --body /tmp/anyps5-pr-precheck/15341-current/pr-body.md
python3 tools/pr_stack_check.py 15341 --repo boykopovar/AnyPS5 --output-dir /tmp/anyps5-pr-precheck/15341-current/stack
gh pr checks 15341 --repo boykopovar/AnyPS5
git show refs/review/15341/20261103-current:core/libs/prx/libSceNgs2.native/src/Voice.cpp | nl -ba | sed -n '748,765p'Results
| Check | Result | Note |
|---|---|---|
| Diff and conventions | passed | Exact-head patch and repository checks passed. |
| Current-main merge preview | passed | Clean against current main. |
| Hosted policy checks | passed | Eligibility, conventions, intake and labels passed. |
| Build and CTest | not applicable | Documentation-only change. |
Unedited check output
All conventions checks passed.
labels pass 8s https://github.com/boykopovar/AnyPS5/actions/runs/41556939091/job/125658006720
edge-watch skipping 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556940511/job/125673101998
linux skipping 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556940511/job/125673101501
register-context skipping 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556940511/job/125673101793
relinker skipping 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556940511/job/125673102215
relinker-asan skipping 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556940511/job/125673101585
windows skipping 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556940511/job/125673101928
write-watch skipping 0 https://github.com/boykopovar/AnyPS5/actions/runs/41556940511/job/125673102439
conventions pass 20s https://github.com/boykopovar/AnyPS5/actions/runs/41556939310/job/125658007310
eligibility pass 5s https://github.com/boykopovar/AnyPS5/actions/runs/41556940511/job/125658009843
intake pass 5s https://github.com/boykopovar/AnyPS5/actions/runs/41556939125/job/125658006768
Negative control
Not applicable: this change adds documentation and has no code assertion or execution path to mutate.
Findings
Blocking
None.
Non-blocking
The PPSA35169 startup observation is stated in the PR description and is author-reported; I did not independently reproduce the title run.
Sources
- NGS2 input validation and throw condition at the reviewed head
- Updated NGS2 debt entry at the reviewed head
Not verified
I did not run PPSA35169 or independently confirm the reported NVIDIA RTX 4080 SUPER run. Linux and Windows build/test jobs were skipped for this documentation-only change.
To get this to a good state
No further change is requested. If the head changes, I will rerun the diff, conventions, stack and applicable hosted-check review on the new SHA.
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
What
The "NGS2 patch destinations" entry says that input 1 is supported only for a voice in a two-input custom submixer and that other nonzero inputs throw because their contracts are unknown. A title reaches that throw, so this adds one sentence to the entry:
Changed:
docs/dev/debt/libSceNgs2.native.md, one existing entry, now 896 characters; the existing text is unchanged. No code change.The title is PPSA35169. It sends the patch through
sceNgs2VoiceControlwithSCE_NGS2_VOICE_PARAM_PATCH(it does not importsceNgs2VoicePatch), andPatchDestincore/libs/prx/libSceNgs2.native/src/Voice.cppthrowsNGS2: voice input 1 is not implemented for this rack, since the destination is a voice handle and its rack is not a custom submixer with more than one input. Which rack it is was not established; a run does not print it, and reading the title's executable shows several racks that could be the destination.No source gives the mixing of a second input outside a custom submixer: here a voice keeps a buffer for an input other than 0 only in its custom-module buffers (
Ngs2Voice::SamplesinNgs2Internal.hpp), which only custom racks use, and KytyPS5 stops on a nonzero input of a rack that is not custom as well, because such a rack has one buffer there (L413-L415). Only its behaviour is described; no code was taken over.Overlap
All 1701 open PRs were checked on 2026-11-02 at 23:11 UTC against
main5cb015caaa. Sixteen changedocs/dev/debt/libSceNgs2.native.mdorVoice.cpp; none changes this entry orPatchDest, and none conflicts with this change. Five of them (#14212, #12107, #11388, #5548, #1384) conflict withmainwith or without it.Tested
Documentation only.
tools/check_conventions.py --base upstream/mainpasses; based onmain5cb015caaa; it merges cleanly intomain7feb37ee3e(2026-11-03 00:20 UTC), which does not change either file. The throw was seen in a 600 s run of PPSA35169 onmain92d2fdc343(2026-11-02 15:28 UTC, libraries built from that commit, NVIDIA RTX 4080 SUPER), 8 s after start; the code that throws is the same on5cb015caaa.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)AI-assisted (Claude Code).
🤖 Generated with Claude Code