Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
✅ AMD GPU test: passedPR head
Unstable on main (2, these also failed in recent main runs on this machine; not counted against this PR)Failing on main too (3, not counted against this PR)Validation IDs already present on main (4 IDs in 446 tests)Skipped (6)ReproduceAutomated build and test on a contributor's AMD machine; it does not replace upstream CI. A new comment is posted for each new push. Full logs. |
Open
12 tasks done
hugodearaujo
added a commit
to hugodearaujo/AnyPS5
that referenced
this pull request
Nov 6, 2026
…hread The test replaces operator new and the operator delete overloads, and its delete frees with std::free, but it left the std::nothrow_t forms of operator new to the runtime. scePthreadAttrInit allocates with new (std::nothrow), so under AddressSanitizer the attribute came from ASan's allocator and went back to free through the test's delete, which ASan reports as alloc-dealloc-mismatch. Allocate the nothrow forms with std::malloc too, as boykopovar#15463 does for guest_cnd_at_thread_exit.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
guest_cnd_at_thread_exittest fails in the Sanitizers nightly of 2026-11-03 (head f6232fc) withAddressSanitizer: alloc-dealloc-mismatch (operator new vs free)atThreads.cpp:222. The test replaces the globaloperator new(size_t)and bothoperator deleteoverloads withmallocandfree, but not the nothrow overload._Mtx_init_nid_postfixallocates its mutex withnew (std::nothrow), which under ASan is still the sanitizer's operator, so the matchingdeletein_Mtx_destroy_nid_postfixreachesfree. The test comes from #10615 (merged 2026-11-02).This PR defines
operator new(std::size_t, const std::nothrow_t&)in the test, usingmallocand returningnullptrwhilefailAllocationsis set, like the throwing overload throws.Changes one file,
core/libs/tests/GuestCndAtThreadExit.cpp(+5).Tested
ANYPS5_ENABLE_ASAN=ONand-fsanitize=undefined -fno-sanitize=vptr(UBSan linked:libubsan.so.1in the test's NEEDED list), on main d1ae628, whoseGuestCndAtThreadExit.cppandThreads.cppare identical to the nightly head.ctest -R '^guest_cnd_at_thread_exit$'failed in 2 of 2 runs withalloc-dealloc-mismatch ... _Mtx_destroy_nid_postfix ... Threads.cpp:222.python -I tools/check_conventions.py --base upstream/mainpassed andgit diff --checkis clean, on the rebased commit at main 4f41f4c.core/libs/testsalso defineoperator new(std::size_t…)without a nothrow overload (GuestAllocationsOom,GuestAmmPool,GuestJsonFloatFailure,GuestPoll,GuestSocketPair,Http2TeardownFailure,JsonCopyFailure,RudpPollWaitException,UltFinalizeAllocation); I did not run them under ASan, and only this one failed in the nightly.Overlap
Checked against main 4f41f4c with the 1684 open PRs listed at 11:07 UTC; the changed files of each PR come from
git diff --name-onlyagainst its merge base, finished 12:09 UTC. No PR changesGuestCndAtThreadExit.cpp. Four PRs opened after the listing (#15449 to #15452) had no fetchable ref; their file lists read through the API (3, 4, 11 and 7 files) do not include it either. Five PRs changelibc/src/Threads.cpp(#12146, #9447, #7648, #5021, #1835); none of their hunks touches_Mtx_initor_Mtx_destroy, and this PR does not changeThreads.cpp.git merge-treeof this head withmainis clean. Depends on: none.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)AI-assisted (Claude Code).
🤖 Generated with Claude Code