Repository navigation
Conversation
BunnyFl
approved these changes
Nov 4, 2026
BunnyFl
left a comment
Contributor
There was a problem hiding this comment.
@brumskysb thanks, the restored clause matches the original. 9ae19f9711 added the entry with "follow the FLOAT_MODE f16/f64 denormal field as measured on RDNA3 (gfx1101, Radeon RX 7700 XT) with the hardware oracle", and fa87e7a722 (merged in #15161) cut that to "(gfx1101)". The four rewordings keep their meaning: the entry still says "denorm16 0..3" before "kept in all four", and "flushes in 0 and 1, kept in 2 and 3" refers to those same modes.
What I checked on head 5be660736d:
- the edited entry (
docs/dev/debt/shader.md:136) is 998 characters by my count, under the 1,000 limit. That's one more than your 997, which leaves 2 to spare; tools/check_conventions.py --base upstream/main: all checks passed, and every relative link in the changed file resolves;tools/pr_overlap.py --branch: no open PR shares lines. It couldn't compare 12 PRs that conflict withmainand touchdocs/dev/debt/shader.md(#9335, #9387, #9748, #10233, #11483, #12548, #13486, #14212, #14217, #14218, #14853, #14871). None of their diffs edits this entry.
Approving.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restores the provenance on the
v_fma_f64andv_div_fmas_f64denormals entry, whichmy own earlier PR (#15161) trimmed down to a bare
(gfx1101):Why it matters more than it looks: this file's value is that a reader can tell what was
measured from what was inferred, and an ISA name hanging off a rule does neither.
(gfx1101)does not say the rule was measured at all, and it does not say on which part. The restored clause
says both. The same PR also dropped
with the hardware oracle; that one stays out for length, andthe row counts that follow in the entry — 3,000 rows per condition on gfx1035, 300 random biased
triples — carry the same evidence.
No behaviour changes, and no measured number changes. One line, one span.
Length was not raised to buy the space. The restored clause costs 34 characters and the
entry had 17 to spare, so 17 come from compression — applied only to phrases I added in #15161,
where meaning is preserved exactly:
flushes in modes 0 and 1 and is kept in 2 and 3flushes in 0 and 1, kept in 2 and 3a product that rounds up to 2^-1022a product rounding up to 2^-1022with an unbounded exponentwith unbounded exponentis kept in every modeis kept in all four983 + 34 − 20 = 997 characters, under the 1,000 limit, so no
debt-lengthwarning appears.The cost is headroom: this leaves 3 characters, where #15161 had left 17. Any future edit to
this entry will have to trim first. Putting the provenance back was worth that, but it should be
on the record rather than discovered later by whoever edits next.
Tested
No measurement in this PR: it restores a condition the original measurement recorded and that a
length trim removed. Nothing in it is a new claim, so there is nothing new to test.
What was checked:
on bit 1, the
2^-1022rounding product, the exact tie's behaviour per mode, and the VCC scaleon
v_div_fmas_f64.check_entry_edit.pyconfirms the edit is confined to this one entry and that every droppedspan is declared (
field (gfx1101);,an,that rounds,every mode,modes,1 and is).tools/check_conventions.py --base origin/mainreports nodebt-lengthfinding for this entry.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)