Repository navigation
Conversation
…ne run per system guest_none_relocations started the relinker 216 times, and on the macOS x86_64 job each start under Rosetta costs about 80 ms, so the test ran for 10.6 to 20.07 s against its 20 s limit and timed out in 6 of the last 25 runs. The 28 valid modules of each SCE variant now share one sce_module directory and one conversion per output system; the invalid modules still convert one at a time. Every guest artifact is byte-identical to the one a single-module conversion writes, and the same checks run on each, so the test starts the relinker 54 times. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
12 tasks done
This was referenced Nov 4, 2026
Keep main's plain and sce modes from boykopovar#15526 and batch the valid modules within each mode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This builds on #15526 by oneandonlydean, now on
main, which splitguest_none_relocationsintoplainandscehalves (guest_none_relocationsandguest_none_relocations_sce, each withTIMEOUT 20). Before the split, the test timed out in 6 of 25 runs of therelinker (macos-latest, clang++, x86_64)job (median 18.89 s) and failed that job on pull requests that do not touch the relinker (#9889 in run 41793009302, #15712, #15715). The split stopped those timeouts. In the 17 latest runs of that job, the halves took a median 9.08 s and 9.19 s, and at most 13.02 s and 13.75 s (65% and 69% of the limit).This PR keeps the split and cuts the work inside each half by three quarters. The time goes into starting processes: each half started the relinker 108 times. On that job the relinker is x86_64 under Rosetta while Python stays native, about 87 ms per start, and the conversions themselves take a few milliseconds.
Within each mode, the 28 valid modules are written into one
sce_moduledirectory as<case>.prx, and each output system converts them in one run (convert_modules). That is 27 relinker starts per half instead of 108. Each module's artifact then gets the samecheck_output, the same--loadrun on Linux x86_64 and the same dynamic-tag check as before. The invalid modules still convert one at a time through the unchangedconvert, since each must fail with its own diagnostic and leave no output. A failing valid check now names its SCE variant, case and system. The test also checks that case names are unique, so two cases cannot share one module file.Batching does not change what is checked:
GuestImageReaderreads each image on its own.main's test and of this one, in each mode, as its system and expected values. The two sets are identical: 84check_outputcalls, 30 dynamic-tag reads and 2--loadruns per half.Other open PRs on this file:
systemstuple would drive the one batch loop here, so the two compose. They conflict textually, so the second to land needs a rebase.convert.The other
TIMEOUT 20relinker tests are not close in the same job. On 4 Nov, over 25 runs, the highest maxima wereautorun_exit_status(8.41 s) andmulx_lowering(8.12 s), and every other one stayed under 6.2 s. They are not changed.Tested
Relinker-only Release builds (
-DANYPS5_RELINKER_ONLY=ON -DBUILD_TESTING=ON) of this branch, which mergesmain4180951e90. The machine is an Intel Core i7-14700K. In each pair,main's test and this one ran back to back against the same relinker binary:main(108 relinker starts)plainsceplainsceOther sessions loaded the Windows machine during the later pairs, which is where the 15.23 s, 19.88 s and 6.46 s runs come from.
plain,sceandallmodes pass, including the--loadruns thatdlopenthe convertedmixedandplt-mixedmodules and call them. Those runs execute only on Linux x86_64.ctest -Rpassesguest_none_relocationsin 2.50 s andguest_none_relocations_scein 2.33 s. It also passes the tests that import helpers from this file:guest_relative_section_symbols,overlapping_relocations,duplicate_relocations,guest_own_tls_relocations,game_patches,annotate_guest_moduleand the sixrestricted_undefined_symbols_*tests.main's test and of this one, then restored:Io::WriteU64(output, earlier->second + 16, addend)replacement fromGuestImageReader.cppfails all four runs onrelative-repeated-1100. This PR reports(False, 'relative-repeated-1100', 'linux', ([(9472, 8, 4096)], [(9472, 8, 4352)])), andTrueforsce.LinuxGuestModuleWriter.cppemitDT_INIT_ARRAYfor an empty init array fails all four runs withAssertionError: unsized-lifecycle.python3 tools/check_conventions.py --base origin/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code