Skip to content

feat(libSceLibreSsl3): implement ASN1_TIME_new and X509_gmtime_adj - #15765

Open
alvaroelpob wants to merge 7 commits into
boykopovar:mainfrom
alvaroelpob:feat/libscelibressl3-asn1-time-new
Open

alvaroelpob wants to merge 7 commits into
boykopovar:mainfrom
alvaroelpob:feat/libscelibressl3-asn1-time-new

Conversation

@alvaroelpob

@alvaroelpob alvaroelpob commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

What

Implements the libSceLibreSsl3 ASN1_TIME_new and X509_gmtime_adj exports as in LibreSSL 4.0.0. ASN1_TIME_new returns an empty multi-string ASN1_TIME from the guest heap. X509_gmtime_adj writes the current time plus an offset as UTCTime for 1950 to 2049 and as GeneralizedTime otherwise, into the given string or a new one.

Tested

Full suite on ecb1623 (Linux): 3883/3883 passed, including the new guest_libressl3_time_new test. It covers ASN1_TIME_new and its allocation failure, X509_gmtime_adj against the host clock, reuse of an existing string, both allocation failures, the UTCTime and GeneralizedTime boundaries at 1950 and 2050, years 0 and 9999, and out-of-range offsets. check_conventions passes.

Checklist

@alvaroelpob
alvaroelpob marked this pull request as ready for review November 4, 2026 13:35
@JJenkx

JJenkx commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Windows check of head ecb162375b, which already contains main b11c7bf84f.

Setup: Windows 11 Enterprise 22621, WinLibs GCC 15.2 UCRT, Release. The hosted Windows check does not run this test on pull requests.

  • guest_libressl3_time_new passes in 3 of 3 runs.

AI-assisted: yes.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Progress report (8ce5134 → ee3b1f0)

📈 System libraries: 27.07% (+0.0053%, +2 implemented functions)

✅ 2 implemented
Library Name
libSceLibreSsl3 ASN1_TIME_new_nid_postfix
libSceLibreSsl3 X509_gmtime_adj_nid_postfix

Changed libraries (implemented exports)

Library Before After Change
libSceLibreSsl3 26/276 (9.42%) 28/276 (10.14%) +0.72%

@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Nov 5, 2026
@alvaroelpob
alvaroelpob force-pushed the feat/libscelibressl3-asn1-time-new branch from ecb1623 to ee3b1f0 Compare November 5, 2026 19:35
@alvaroelpob

Copy link
Copy Markdown
Contributor Author

Rebased on main ce69412 to resolve the new conflicts. Head ee3b1f0. Full Linux suite: 4087/4087. check_conventions.py passes.

@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Nov 5, 2026
@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Nov 6, 2026
@alvaroelpob
alvaroelpob force-pushed the feat/libscelibressl3-asn1-time-new branch from ee3b1f0 to 964a73b Compare November 6, 2026 09:40
@alvaroelpob

Copy link
Copy Markdown
Contributor Author

Rebased on main 018cfcb to resolve the new conflicts. Head 964a73b. Fixes from the rebase, as new commits: 964a73b (build(libSceLibreSsl3): list the new test before PROPERTIES in the shared Windows PATH entry); The build commit fixes a mistake from my previous rebase: the new test name had ended up after ENVIRONMENT_MODIFICATION in the shared Windows set_tests_properties, which made CMake configuration fail on Windows (the earlier Windows check failure). Full Linux suite: 4168/4168. check_conventions.py passes.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build docs needs rebase Conflicts with main, rebase needed prx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants