Repository navigation
refactor(prx): name the LibcInternal Err.cpp pending stubs the NID database resolves - #15989
Open
ItsJustChrisE wants to merge 1 commit into
Open
ItsJustChrisE wants to merge 1 commit into
ItsJustChrisE wants to merge 1 commit into
Conversation
…tabase resolves Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Progress report (1e24993 → fe854e0)➖ System libraries: 26.48% (+0.0%, +78 declared, -78 removed functions) 🆕 78 declared as stubs
🗑️ 78 removed
Changed libraries (implemented exports)
|
12 tasks done
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Names 78 of the 149
sceLibcInternalPending3_*_nid_no_patchplaceholders inlibSceLibcInternal/Err.cppafter the symbolstools/nid_names.pyresolves through its pinned aerolib database, the same names the libSceLibcInternal debt file already lists for them. As in #15678 and #15777, the names carry the_nid_postfixsuffix so they never collide with the host C++ runtime, and they are declared once in the newinclude/ErrExports.hpp, which the library umbrella header includes.The other 71 are left as they are, because #15582, #15711, #15712, #15715 and #15830 implement or edit them or the stubs next to them; renaming them here would conflict with those PRs. They can be named once those land.
Every renamed body still throws through
NotImplemented_nid_no_patch, and the library exports the same NIDs as onmain. A title that reaches one now fails with the function's name instead of the placeholder's. The debt entries already name each export, so they are unchanged.Tested
Ubuntu 26.04.1 on WSL2, GCC 15.2.0, Release,
main1e24993fa3. No title or homebrew run.compute_nid(name) == nidfor all 78.nm -Don the patchedlibSceLibcInternal.prxofmainand this branch, ignoring the removed_nid_no_patchhelper names: identical NID sets (1167); the placeholder helpers drop from 901 to 823.ctest -R 'public_headers|patched_librar': 66 of 66 passed.tools/check_conventions.py --base origin/main: passed.tools/pr_overlap.py --branch: 1895 open pull requests probed, no shared lines or exports inErr.cpp. fix(relinker): match AppContent utility import to provider #13486 and feat(libSceLibcInternal): implement floating-point word access #13782 already conflict withmain, so the tool could not comparelibSceLibcInternal.hpp. Test-merging each intomainand into this branch withgit merge-treegives the same conflicting files, and the include sits where it also merges cleanly with refactor(prx): name the LibcInternal round 6 stubs the NID database resolves #15678 and refactor(prx): name the LibcInternal round 7 stubs the NID database resolves #15777.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code