Repository navigation
fix(agc): leave a single-sample view over a published native multisample depth owner to guest memory - #16365
Open
hugodearaujo wants to merge 4 commits into
Conversation
…ILE to its depth and stencil planes
…ication # Conflicts: # docs/dev/debt/libSceAgcDriver.md
… stay unimplemented
…ple depth owner to guest memory
Contributor
|
Correction (rerun): my first run rebuilt only the main test target, but the test pattern also matched Windows check of head Setup: Windows 11 Enterprise 22621, WinLibs GCC 15.2 UCRT, Release, Radeon RX 6700 XT, AMD driver 26.10.1. Run through the Windows test queue with
AI-assisted: yes. |
Contributor
✅ NVIDIA GPU test: passedPR head
Unstable on main (1, these also failed in recent main runs on this machine; not counted against this PR)Failing on main too (4, not counted against this PR)Validation IDs already present on main (9 IDs in 588 tests)Skipped (53)ReproduceAutomated build and test on a contributor's NVIDIA machine; it does not replace upstream CI. A new comment is posted for each new push. Full logs. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A title can read the memory of a native multisample D32S8 target without HTILE through a single-sample view at the depth base. Assassin's Creed Mirage (PPSA13960) does: a compute reads mip 0 of an R11G11B10F chain it wrote over the planes, at the depth address (
resource 0x10f5d40000 3440x1936 x1 fmt 36against the owner1720x968 x4).DepthSurfaceTexturetakes every view at the base of an owner into the native path, and a single-sample view fails its identity check there:native multisample depth sampled identity or format mismatch.For an owner the host has not written since its import or its last publication (#15688), guest memory already holds every sample. The import only accepts planes that each hold one value, and a publication writes all samples back to the planes.
This change:
DepthSurface::GuestHoldsSamples: a multisampled owner without HTILE, imported for sampling, with no refusal, not written by the host since its import or publication;Tested
Linux 7.2.11, AMD Radeon RX 9070 XT, RADV (Mesa 26.2.6), Release with tests.
agc_driver_native_depth_single_sample_view(--single-sample-view), at 2, 4 and 8 samples, on a 200x130 D32S8 target without HTILE whose planes hold 1.0 and 0x5a. A single-sample R11G11B10F view (400x260,kStandard64KB) at the depth base:AGC graphics: native multisample depth sampled identity or format mismatch.VK_INSTANCE_LAYERS=VK_LAYER_KHRONOS_validation,ANYPS5_NO_SHADER_CACHE=1,ANYPS5_REQUIRE_VULKAN=1,ctest -V -R "native_depth|native_multisample|depth_storage|depth_surface|agc_storage_|multisample_guest|repeat_storage_guard|cached_image|storage_flush_ordering|storage_one_slice|storage_read_during|storage_write_back|msaa_address_on_plane", 55 tests):VUID-line or "was not found but was requested". Both have the same 20WARNING-VkImageSubresourceRange-layerCount-compatibilitylines.tools/check_conventions.py --base fa590e435a: passes.compute shader 0x10b4c8ad00: AGC graphics: native multisample depth sampled identity or format mismatch(the read above). This change is one of four that move the title pastnative multisample depth plane without HTILE does not hold one depth value in [0, 1]: fix(agc): import a native multisample D32S8 target over uneven planes once its first draw wrote every sample #16363 (overwrite proof), fix(agc): publish native multisample depth next to a storage image whose pending units lie past its planes #16364 (pending units) and fix(agc): publish a reused native multisample depth target with the guest's undecided bytes, then retire its owner #15941 (or a change that starts a new owner under pending storage results). Its effect shows only together with the others, so the runs are in fix(agc): import a native multisample D32S8 target over uneven planes once its first draw wrote every sample #16363. In short, onmain5299939 + fix(agc): store storage results pending under a multisampled color target before it takes the memory #13963 (7d54822) + fix(agc): release a published native multisample depth owner whose plane a written storage view covers #15707 (a8c5df4), the run without the changes stopped at 484 s on that message, and none of the four runs with them stopped on it or on the identity mismatch (their stops, all later and separate: 452 s and 468 s, or the local VRAM guard at 482 s and 496 s).Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)