Repository navigation
feat(libc): implement logb, sinhf, nearbyintf and __powisf2 - #2037
Aryansh1520 wants to merge 3 commits into
Conversation
PPSA28997 imports them. __powisf2 follows compiler-rt: repeated squaring in float, with the reciprocal taken at the end for a negative exponent.
|
Please add focused tests to guest_math for logb, sinhf, nearbyintf and powisf2, including exponents 0, -1 and INT_MIN, plus special values. The for-loop increment squares base after remaining has become zero; exponent 1 therefore computes an unused FLT_MAX * FLT_MAX, which can raise overflow. LLVM compiler-rt stops before that final square (reference: https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/builtins/powisf2.c). I built exact head 23c84b2 on Linux with GCC 12; the existing guest_math passed 1/1 in 0.02 s and conventions passed, but that test does not cover these new exports. No GitHub checks are reported for this head. |
|
Which of these does PPSA28997 stop at on main? Please add that log line; with it and the tests MarcZX100 asked for, this can go in. |
|
Updated in a046106.
On where PPSA28997 stops: I don't have a log line for these four. I found them statically, among the unresolved imports of the title's modules ( The build workflows on this head are waiting for approval to run (fork PR). |
|
Native Windows run, since no Windows results were posted. Setup: Windows 10 (19045), MinGW-w64 GCC 15.2.0 (WinLibs r7), Release. Head
No title was run. 🤖 Addressed by Claude Code |
|
Closing: on main PPSA28997 stops at |
…f and __powisf2 checks to their own test Harvested from upstream (closed unmerged); library completion 2835/3232 -> 2839/3236. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011krDVCnnMQPaEFEqCDnKmA
What
PPSA28997 (God of War Sons of Sparta) imports these four functions, and none of them is exported yet.
logb,sinhfandnearbyintfforward to the C++ standard library, like their existing neighbours (logbf,sinf).__powisf2, the compiler-rt helper forpowion floats, uses compiler-rt's algorithm: repeated squaring infloat, then the reciprocal for a negative exponent.Tested
tools/check_conventions.py --base origin/mainandtools/pr_overlap.py --branchpass.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)