Repository navigation
fix(libc): translate asprintf encoding errors to guest errno - #2094
Closed
STUPIDCONTEM wants to merge 1 commit into
Closed
STUPIDCONTEM wants to merge 1 commit into
STUPIDCONTEM wants to merge 1 commit into
Conversation
8 of 9 tasks
9 tasks done
Collaborator
|
Closing: this fixes one errno value on one Linux-only path, and no title is shown reaching it. If a title checks for EILSEQ from asprintf, please reopen with its ID and the log line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence review (2026-10-09)
Closed by maintainer; not ready to reopen. Required evidence: Title ID and a log showing a title reaches the Linux asprintf encoding-error path and needs guest EILSEQ.
Game/title ID: none verified. No PS5 title execution is claimed.
What
Translate host EILSEQ to guest FreeBSD EILSEQ when asprintf_nid_postfix fails to format an invalid wide character. On Linux, host vasprintf returns errno 84, but the guest ABI uses 86. The change handles only this failed conversion; successful formatting and other errors retain their existing behavior.
The error is specified for the printf family by FreeBSD vfprintf(3), and stable/11 errno.h defines EILSEQ as 86. Open #1804 changes the separate vasprintf wrapper's wide-format routing in Formatting.cpp; it does not change asprintf_nid_postfix in AllocatingStrings.cpp.
Tested
The changed host-formatting path and new regression are excluded on Windows. Windows runs validate existing behavior and build compatibility; they do not establish this Linux error correction. No title run was performed.
Checklist