Repository navigation
Conversation
8 of 9 tasks
9 tasks done
Contributor
9 tasks done
Collaborator
|
Closing: the full-tree scan in your description gives the same per-library counts as main, so nothing is miscounted today. Please reopen if a source file on main gets counted wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The library progress scanner counted commented-out or quoted
APS5_VABIdefinitions and treated braces inside literals as function boundaries. For example, a"}"string beforeNotImplemented_nid_no_patchmade a pending export appear implemented.import_audit.pyuses the same scanner.Mask C++ comments, ordinary/raw strings and character literals before scanning definitions, bodies and local stub wrappers. Handle escaped newlines and match stub calls by complete name with optional whitespace/comments before
(, avoiding matches in longer identifiers or diagnostic text. Add regression coverage in the existing progress tests.Tested
Windows, Python 3.14.3:
python -m unittest discover -s tools/tests: 27 tests passed, including progress reporting and import audits.python tools/check_conventions.py --base origin/mainandgit diff --check origin/main...HEADpass.Open-PR changed-file checks were refreshed before implementation, during validation and before publication; no other PR changes
tools/progress.pyortools/tests/test_progress.py. Related #1323 changes the separate conventions checker.No C++ runtime changes; no title or hardware testing.
Checklist
main; no other open PR implements the same functions