[Zheorgyan]

What

with APS5_DEBUG_LOG defined, LogMacros.hpp defines APS5_LOG_DEBUG, which nothing uses, and leaves APS5_LOG_OUT_DEBUG undefined, so Pm4.cpp, VulkanDevice.cpp and State.cpp stop compiling and the debug logs can't be turned on. the macro under APS5_DEBUG_LOG is APS5_LOG_OUT_DEBUG now, matching the #else branch

Tested

• Linux, Ubuntu 24.04 in Docker, GCC 14.2. the four files that use the debug macros, Pm4.cpp, VulkanDevice.cpp, Draw.cpp and State.cpp, compiled with their build commands plus -DAPS5_DEBUG_LOG. before, three fail with "'APS5_LOG_OUT_DEBUG' was not declared in this scope", after, all four compile. without the define nothing changes
• tools/check_conventions.py passes

Checklist

• Based on current main; no other open PR implements the same functions
• One topic per PR; follow-ups go in a new PR
• No comments in code except technical debt
• Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt
• No notes, investigation .md files or images added to the repository (attach them to this PR)
• New third-party code is a submodule built from source
• Generic behaviour, not specific to one title
• Depends on: none
• AI-assisted: yes

[MarcZX10]

Reviewed the full diff. Renaming the enabled-branch macro to APS5_LOG_OUT_DEBUG matches the disabled branch and the call sites described in the PR; the reported compile checks exercise the affected translation units. Conventions passes. The full Build workflow is not present on this head, so I am holding formal approval until an authorized collaborator runs it on the exact PR revision.

[popcoder565]

Native Windows run, since no Windows results were posted. Setup: Windows 10 (19045), MinGW-w64 GCC 15.2.0 (WinLibs r7), Release. Head eec5c182, merged onto main d70b899 in one build with 38 other PRs that had no Windows run.

• This PR has no test of its own. It builds, and the full suite passes.
• Full ctest in that build: 519 of 519. That needed local fixes to three other PRs in the batch that don't build or pass on Windows: feat(libc): export scriptingGetMem and scriptingFreeMem from application heap #1611, feat(posix): implement gethostbyname #1796 and feat(zlib): implement sequential libSceZlib decompression #1824 (reported there).

No title was run.

🤖 Addressed by Claude Code