Skip to content

feat(libSceJson2): implement InitParameterRtti and MemAllocator::notifyError - #2309

Closed
Darkeox34 wants to merge 1 commit into
boykopovar:mainfrom
Darkeox34:feat/json2-complete-exports
Closed

Darkeox34 wants to merge 1 commit into
boykopovar:mainfrom
Darkeox34:feat/json2-complete-exports

Conversation

@Darkeox34

@Darkeox34 Darkeox34 commented Oct 9, 2026 •

Copy link
Copy Markdown

What

Completes 100% export coverage for libSceJson2:

  • Implements _ZN3sce4Json17InitParameterRttiC1EPNS0_14AllocParamRttiEPvm
    (sce::Json::InitParameterRtti::InitParameterRtti).
  • Implements _ZN3sce4Json12MemAllocator11notifyErrorEimPv
    (sce::Json::MemAllocator::notifyError).
  • Adds unit tests in core/libs/tests/GuestJson.cpp.
  • Updates docs/dev/TechnicalDebt.md.

Tested

  • Unit test suite (GuestJson).
  • python tools/check_conventions.py --base upstream/main.
  • python tools/progress.py.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in
    TechnicalDebt
  • No notes, investigation .md files or images added to the repository
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • AI-assisted: yes

Summary of Changes

Target Description
core/libs/prx/libSceJson2/Export.cpp Implement _ZN3sce4Json17InitParameterRttiC1EPNS0_14AllocParamRttiEPvm (sce::Json::InitParameterRtti)
core/libs/tests/GuestJson.cpp Add unit tests verifying InitParameterRtti struct member initialization and null pointer validation
docs/dev/TechnicalDebt.md Document structural assumptions and layout details for sce::Json::InitParameterRtti
  • Passes convention checks (python tools/check_conventions.py --base upstream/main).

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
#2308 core/libs/tests/GuestJson.cpp L88

@Darkeox34
Darkeox34 force-pushed the feat/json2-complete-exports branch from 211897c to 5270c5c Compare October 9, 2026 16:34
@AnzouBelilita

Copy link
Copy Markdown

Independent Windows validation for PR #2309:

  • OS: Windows 10 Pro, build 19045
  • Toolchain: MinGW-w64 GCC 16.2.0, CMake 4.4.4, Ninja 1.13.2
  • Configured the project in Release mode with BUILD_TESTING=ON.
  • Built guest_json_tests successfully (96 build steps).
  • CTest: guest_json passed (1/1, 0 failures).
  • python tools/check_conventions.py --base d70b89989473ba1f6ae13e44e079e67f1f8a44b0 passed.
  • git diff --check d70b89989473ba1f6ae13e44e079e67f1f8a44b0...HEAD passed.
  • Tested PR head: 5270c5cfad36b3fd9b0b9aac710d864537053fc8.

This confirms that the PR builds and its JSON tests pass on native Windows. It does not resolve the competing notifyError implementations in #2308 and #2309, nor verify PS5-specific behavior.

No production code was modified during validation.

@oneandonlydean

Copy link
Copy Markdown
Collaborator

Closing: export coverage alone isn't a reason to add these, and no title is shown reaching InitParameterRtti or notifyError on main. Please reopen with the title ID and the log line if one does.

ycbuzi pushed a commit to ycbuzi/AnyPS5 that referenced this pull request Oct 10, 2026
Harvested from upstream (closed unmerged); library completion 2925/3297 -> 2926/3297. Additive conflicts resolved by keeping both sides: core/libs/tests/GuestJson.cpp.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011krDVCnnMQPaEFEqCDnKmA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants