Repository navigation
Conversation
This was referenced Oct 9, 2026
Darkeox34
force-pushed
the
feat/json2-complete-exports
branch
from
October 9, 2026 16:34
211897c to
5270c5c
Compare
|
Independent Windows validation for PR #2309:
This confirms that the PR builds and its JSON tests pass on native Windows. It does not resolve the competing No production code was modified during validation. |
Collaborator
|
Closing: export coverage alone isn't a reason to add these, and no title is shown reaching |
9 tasks done
ycbuzi
pushed a commit
to ycbuzi/AnyPS5
that referenced
this pull request
Oct 10, 2026
Harvested from upstream (closed unmerged); library completion 2925/3297 -> 2926/3297. Additive conflicts resolved by keeping both sides: core/libs/tests/GuestJson.cpp. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011krDVCnnMQPaEFEqCDnKmA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes 100% export coverage for
libSceJson2:_ZN3sce4Json17InitParameterRttiC1EPNS0_14AllocParamRttiEPvm(
sce::Json::InitParameterRtti::InitParameterRtti)._ZN3sce4Json12MemAllocator11notifyErrorEimPv(
sce::Json::MemAllocator::notifyError).core/libs/tests/GuestJson.cpp.docs/dev/TechnicalDebt.md.Tested
GuestJson).python tools/check_conventions.py --base upstream/main.python tools/progress.py.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed inTechnicalDebt
.mdfiles or images added to the repositorySummary of Changes
core/libs/prx/libSceJson2/Export.cpp_ZN3sce4Json17InitParameterRttiC1EPNS0_14AllocParamRttiEPvm(sce::Json::InitParameterRtti)core/libs/tests/GuestJson.cppInitParameterRttistruct member initialization and null pointer validationdocs/dev/TechnicalDebt.mdsce::Json::InitParameterRttipython tools/check_conventions.py --base upstream/main).