[reyani-dev]

What

On FreeBSD, unlink (and so remove) ignores the file's own permission bits: what matters is write access to the directory. A guest that does chmod(path, 0400) and later remove(path) therefore succeeds on the console.

On Windows, the guest chmod (_wchmod) sets FILE_ATTRIBUTE_READONLY when the write bit is cleared. DeleteFileW then fails with ERROR_ACCESS_DENIED, so remove returned -1 with EACCES, and the file stayed.

When the entry carries FILE_ATTRIBUTE_READONLY (the attributes are already read), remove now clears it before the single delete. If the delete fails (e.g. the file is open without delete sharing), it restores the original attributes and reports the delete's error, so a failed remove leaves the file as it was. Linux is unchanged.

Tested

Windows 11, WinLibs GCC 15.2.0 r7, Release, -DBUILD_TESTING=ON:

• guest_filesystem: a file made read-only with sceKernelChmod(0400) is removed by remove, and no longer exists.
  • On main it fails at that line with guest errno 13.
  • With the fix it passes. On Linux the case already held, and it still does.
• Probed separately on the fixed build:
  • a read-only file held open by another handle: remove fails (EBUSY), the file stays, and FILE_ATTRIBUTE_READONLY is restored;
  • guest chmod never sets the attribute on directories, so directory removal is unaffected.
• ctest -E "^agc_|video_out": 249/249.
• tools/check_conventions.py passes, and tools/pr_overlap.py --branch reports no overlap. It also merges cleanly with the open PRs that touch GuestFilesystem.cpp and Filesystem.cpp: feat(libkernel): export the POSIX rename #1192, feat(libkernel): implement fdatasync #1620, feat(libkernel): implement lstat #1624, fix(libkernel): honour open flags when Windows falls back to a directory descriptor #1628, fix(libkernel): give flock BSD semantics on Windows #1755, fix(libkernel): return EWOULDBLOCK from a contended LOCK_NB flock #1764, feat(libkernel): open /dev/random and /dev/urandom for reading #1777, fix(libkernel): report EISDIR for path truncation #2086, fix(libkernel): report Linux file birth times accurately #2115, feat(libkernel): implement sceKernelFdatasync #2129, fix(files): isolate guest descriptors from host resources #2170, fix(libkernel): report POSIX rename errors from sceKernelRename #2260, fix(libkernel): return EPERM when unlinking a directory #2289 and fix(libkernel): report ENOTDIR from stat for a file with a trailing slash #2300.

sceKernelUnlink/unlink in libkernel likely behave the same way on Windows. They are left for a separate PR, because #2289 changes that function.

A Linux and Windows full build will be posted here once it has run.

Checklist

• Based on current main; no other open PR implements the same functions
• One topic per PR; follow-ups go in a new PR
• No comments in code except technical debt
• Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt
• No notes, investigation .md files or images added to the repository (attach them to this PR)
• New third-party code is a submodule built from source
• Generic behaviour, not specific to one title
• Depends on: none
• AI-assisted: yes

🤖 Generated with Claude Code

[reyani-dev]

Full Linux and Windows builds and tests for this head (58e18f08), using the project's Build workflow. I can't start the upstream manual run, so I ran the same build.yml in my fork through a mirror PR. Like the upstream run, the jobs check out the PR head merged into current main (d70b8998):

Job	Result
linux	success; full build, ctest: 516/516 passed
windows	success; full build, ctest: 507/507 passed
relinker (Linux, Windows, macOS)	success

Run: https://github.com/AchrafReyani/AnyPS5/actions/runs/37955618179

[oneandonlydean]

remove_nid_postfix deletes, and on ERROR_ACCESS_DENIED clears the read-only attribute and deletes again (Filesystem.cpp:121-136). Retrying after an error isn't allowed here; attributes is already read, so please clear FILE_ATTRIBUTE_READONLY before the first delete when it's set (restoring it if that delete fails), and drop the second attempt.

[reyani-dev]

Done in e8d4c02: remove now clears FILE_ATTRIBUTE_READONLY before the single delete when it is set, and restores the original attributes if that delete fails. The second attempt is gone.

I rechecked on Windows:

• guest_filesystem passes;
• a read-only file held open by another handle still fails with EBUSY, stays in place and keeps its read-only attribute;
• ctest -E "^agc_|video_out" is 249/249, and check_conventions.py passes.

The Linux and Windows full build for the new head is running and will be posted here.

[reyani-dev]

Full Linux and Windows builds and tests for this head (e8d4c022), using the project's Build workflow. I can't start the upstream manual run, so I ran the same build.yml in my fork through a mirror PR. Like the upstream run, the jobs check out the PR head merged into current main (d70b8998):

Job	Result
linux	success; full build, ctest: 516/516 passed
windows	success; full build, ctest: 507/507 passed
relinker (Linux, Windows, macOS)	success

Run: https://github.com/AchrafReyani/AnyPS5/actions/runs/37986819849