Skip to content

refactor(libSceNpPartner001): name the EA access exports - #2344

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
mrzacarias:refactor/np-partner-name-ea-access
Oct 9, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
mrzacarias:refactor/np-partner-name-ea-access

Conversation

@mrzacarias

Copy link
Copy Markdown
Contributor

What

Resolve the two unknown libSceNpPartner001 NIDs: 7CxI50-xlCk is sceNpEAAccessInitialize and pMxXhNozUX8 is sceNpEAAccessTerminate, as shadPS4 names them in src/core/libraries/np/np_partner.cpp. Both names hash to their NIDs with compute_nid.

  • The APS5_EXPORT aliases go; the NIDs are computed from the names.
  • Behaviour is unchanged: both still throw NotImplemented_nid_no_patch.
  • The TechnicalDebt entry records the names and no-argument signatures follow shadPS4, unconfirmed on a PS5 title.

Tested

  • python3 tools/check_conventions.py --base origin/main passes.
  • tools/nid_names.py: 22 -> 20 unknowns (the two NpPartner001 NIDs no longer scan as unknown).

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw; silent stubs are listed in TechnicalDebt
  • No notes, investigation .md files or images added to the repository
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • AI-assisted: yes

sceNpEAAccessInitialize and sceNpEAAccessTerminate resolve the NIDs
7CxI50-xlCk and pMxXhNozUX8, which shadPS4 names in np_partner.cpp. The
stubs still throw; only the names and no-argument signatures change.
@popcoder565

Copy link
Copy Markdown
Contributor

Native Windows run, since no Windows results were posted. Setup: Windows 10 (19045), MinGW-w64 GCC 15.2.0 (WinLibs r7), Release. Head fc3e2345, merged onto main f8c2f07 in one build with 9 other PRs that had no Windows run.

No title was run.

🤖 Addressed by Claude Code

@adriadam10

Copy link
Copy Markdown
Collaborator

Checked: both names hash to their NIDs with compute_nid, shadPS4 np_partner.cpp has both with no arguments, TechnicalDebt line sits in "Unknown function info" and states the unconfirmed signature. Build and ctest green on main + this PR (459/459), confirmed on Windows by @popcoder565. Merging.

@adriadam10
adriadam10 merged commit 5694d3f into boykopovar:main Oct 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants