Repository navigation
refactor(libSceNpPartner001): name the EA access exports - #2344
Merged
adriadam10 merged 1 commit intoOct 9, 2026
Merged
Conversation
sceNpEAAccessInitialize and sceNpEAAccessTerminate resolve the NIDs 7CxI50-xlCk and pMxXhNozUX8, which shadPS4 names in np_partner.cpp. The stubs still throw; only the names and no-argument signatures change.
9 tasks done
Contributor
|
Native Windows run, since no Windows results were posted. Setup: Windows 10 (19045), MinGW-w64 GCC 15.2.0 (WinLibs r7), Release. Head
No title was run. 🤖 Addressed by Claude Code |
Collaborator
|
Checked: both names hash to their NIDs with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolve the two unknown libSceNpPartner001 NIDs:
7CxI50-xlCkissceNpEAAccessInitializeandpMxXhNozUX8issceNpEAAccessTerminate, as shadPS4 names them insrc/core/libraries/np/np_partner.cpp. Both names hash to their NIDs withcompute_nid.APS5_EXPORTaliases go; the NIDs are computed from the names.NotImplemented_nid_no_patch.Tested
python3 tools/check_conventions.py --base origin/mainpasses.tools/nid_names.py: 22 -> 20 unknowns (the two NpPartner001 NIDs no longer scan as unknown).Checklist
main; no other open PR implements the same functions.mdfiles or images added to the repository