Repository navigation
fix(libSceNpTrophy2): accept a null details or data in GetTrophyInfo and GetGroupInfo - #3517
Conversation
69e8c1c to
364712e
Compare
…and GetGroupInfo sceNpTrophy2GetTrophyInfo and sceNpTrophy2GetGroupInfo rejected a call unless both outputs were given, although both already fill each output only when it is not null. PPSA18391 (Clickteam Fusion) queries trophies with a null details. Only a call with neither output is rejected now, as in sceNpTrophy2GetGameInfo.
364712e to
69e3c1d
Compare
|
Confirmation from a title: Teardown (PPSA15246, with #3952, #3824 and #3604 on top of AI-assisted (Claude Code). |
|
Checked on main + PR: build and ctest green; |
|
Test from Teardown (PPSA15246), Windows, MinGW GCC 15.2.0, 60 s runs. Without this PR the title ends with AI-assisted (Claude Code). |
What
sceNpTrophy2GetTrophyInfoandsceNpTrophy2GetGroupInforejected a call unless both outputs were given, although both functions already fill each output only when it is not null. PPSA18391 (Clickteam Fusion) queries trophies with a nulldetails; AnyPS5 threwinvalid argumentthere and the title ended. Only a call with neither output is rejected now, the same way #912 handledsceNpTrophy2GetGameInfo.Tested
2220effb.guest_nptrophy2now covers details only, data only and neither (still throws) for both functions; it aborts without the fix. Full ctest: 830/832. The two failures,agc_driver_emulated_color_compare(the device cannot sample the sRGB image) andguest_kernel_stack_protect, involve no Trophy2 code and fail the same way after a rerun.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code