Skip to content

feat(libSceShare): implement extended video clip capture - #3720

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
MarcZX10:codex/share-clip-extended-3333
Oct 12, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
MarcZX10:codex/share-clip-extended-3333

Conversation

@MarcZX10

Copy link
Copy Markdown
Contributor

What

Implements sceShareCaptureVideoClipExtended with the same unsupported-capture result as its screenshot sibling, adds guest coverage for valid and null arguments, and records the unverified signature and behavior in TechnicalDebt.

Carried David's ready commit unchanged, preserving its author metadata.

Tested

Independent Linux Release verification on the rebased change: guest_share and the full suite (520/520) passed; conventions and git diff --check passed. The original Windows Release report records guest_share 3/3 and full suite 507/507 (excluding AGC driver and video flip tests; it notes an unrelated #3329 test fix applied locally). Verification details are in issue #3333.

Checklist

  • Based on current main; no other open PR implements the same function
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw
  • No notes or investigation files added
  • Generic behavior
  • Depends on: none
  • AI-assisted: yes

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Progress report (1acfa7f → f3a6edf)

📈 System libraries: 86.39% (+0.03%, +1 implemented functions)

✅ 1 implemented
Library Name
libSceShare sceShareCaptureVideoClipExtended

@adriadam10

Copy link
Copy Markdown
Collaborator

Rebased onto current main (only conflict: adjacent TechnicalDebt.md line, both kept); guest_share passes after the rebase. Merging once CI is green.

@github-actions github-actions Bot added needs rebase Conflicts with main, rebase needed and removed needs rebase Conflicts with main, rebase needed labels Oct 11, 2026
@oneandonlydean

Copy link
Copy Markdown
Collaborator

A title is required for this to merge: which title calls sceShareCaptureVideoClipExtended on main? With the title ID and the log line where it stops, this can go in.

@adriadam10

Copy link
Copy Markdown
Collaborator

@copilot Rebase this branch onto current main and resolve the conflict in docs/dev/TechnicalDebt.md: both sides only add lines at the same place, so keep the lines from main and then the lines from this branch, unchanged. Do not create a merge commit and do not change anything else.

@adriadam10

Copy link
Copy Markdown
Collaborator

@copilot Mechanical rebase only. Please:

  1. Rebase this branch onto current main (git rebase origin/main). No merge commit, no squash, keep every commit with its message and author.
  2. The only expected conflict is in docs/dev/TechnicalDebt.md, where main and this branch both add lines at the same place. Resolve it by keeping the lines from main first and then the lines from this branch, byte for byte. Do not reword, reorder, deduplicate or move any line.
  3. If any conflict is not of that kind (a line changed on both sides, or a conflict in another file), stop: abort the rebase, push nothing, and reply here with the conflicting file and lines.
  4. Check before pushing: git diff origin/main...HEAD must be the same change as this pull request had before the rebase, and python3 tools/check_conventions.py --base origin/main must pass. Do not run the build or the tests: CI is limited and a reviewer runs them before merging.
  5. Force-push the rebased branch to this pull request's head branch. Do not open a new pull request and do not change the pull request title or description.

@MarcZX10
MarcZX10 force-pushed the codex/share-clip-extended-3333 branch from d39a307 to 72c1fd2 Compare October 12, 2026 18:42
Imported by the Share plugin of Hollow Knight: Silksong (PPSA12544).
Takes the extended parameter and request id like
sceShareCaptureScreenshotExtended, as KytyPS5 does: nothing is
captured, so it stores the invalid request id -1 when the pointer is
not null and returns NOT_SUPPORTED.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
(cherry picked from commit 2450909)
@MarcZX10
MarcZX10 force-pushed the codex/share-clip-extended-3333 branch from 72c1fd2 to f3a6edf Compare October 12, 2026 18:48
@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 12, 2026
@adriadam10

Copy link
Copy Markdown
Collaborator

Checked on current main: guest_share passes with the change and fails without it; the new export matches sceShareCaptureScreenshotExtended (NOT_SUPPORTED, request id -1), and the debt entry is under "Functional". Merging.

@adriadam10
adriadam10 merged commit 0142215 into boykopovar:main Oct 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants