Repository navigation
feat(libkernel): answer getrlimit for FreeBSD resources - #3765
Conversation
adriadam10
left a comment
There was a problem hiding this comment.
Thanks. The getrlimit part checks out: the nine values match FreeBSD 11.4 proc0_init (sys/kern/init_main.c, all limits start at RLIM_INFINITY; only NOFILE/NPROC/DATA/STACK/RSS/MEMLOCK are overridden, and those are the ones you keep throwing). Tests pass locally and fail without the change.
One blocker:
wait(Process.cpp:293,GuestWaitpid.cpp:14-23, thewait and waitpidTechnicalDebt line) is already implemented by the open #3715 (same forwarding towaitpid(-1, status, 0), same test), opened earlier. CONTRIBUTING doesn't allow two open PRs implementing the same function.
Please drop the wait parts and keep this PR to getrlimit (restore the original waitpid TechnicalDebt line, add only the getrlimit one, and update the title/body, with "Depends on: none"). It can then be merged independently of #3715.
Implementation Details & Expedited Testing RequestHi @adriadam10, @MarcZX100, @blawesom, This PR directly addresses the start-up crashes across PS5MC (PPSA99420), XPSemu (PPSA97358), and VLC (PPSA85300) as reported in #3733:
|
060a4a2 to
13fc1fe
Compare
Clean Scope UpdateTo maintain strict one-topic focus and avoid any duplicate export collisions with @Lorkydey's PR #3715 (which exports wait), this PR has been narrowed purely to getrlimit (eat(libkernel): answer getrlimit for FreeBSD resources):
|
|
Hi @adriadam10, Thank you for the review and confirmation on the FreeBSD 11.4 proc0_init values! I have addressed the blocker exactly as requested:
Ready for re-review and merge. Thank you! |
13fc1fe to
ad05112
Compare
|
Hi @adriadam10 and @oneandonlydean, Rebased cleanly onto latest origin/main (d371ed3) on commit �d051126d:
Branch is clean (mergeable: true) and ready for review and merge when convenient! Thank you! |
ad05112 to
7146d9c
Compare
7146d9c to
2781077
Compare
|
Hi @adriadam10, following up on your earlier review: as requested, wait was completely removed to avoid overlap with #3715, and this PR is now strictly scoped to the 9 FreeBSD process-0 getrlimit defaults (RLIMIT_CPU, FSIZE, CORE, SBSIZE, VMEM, NPTS, SWAP, KQUEUES, UMTXP). Rebased cleanly on latest main with all 14 CI checks passing (mergeable: true). Whenever you have a chance to re-review, thank you! |
The points from this review are in the current head.
What
This pull request implements FreeBSD 11 process-0 baseline resource limits in getrlimit within libkernel: