Repository navigation
feat(libkernel): implement getsid - #4192
Closed
codingreapermaps wants to merge 1 commit into
Closed
codingreapermaps wants to merge 1 commit into
codingreapermaps wants to merge 1 commit into
Conversation
Follow FreeBSD's kern_getsid for the only guest process: 0 and its own pid return its session id, any other pid reports ESRCH. The guest is taken to lead its own session, so the session id is its own pid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 12, 2026
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
Contributor
Author
|
Closing as a duplicate of #4170, which was opened first and implements the same behaviour. Sorry for the overlap, it wasn't open yet when I started on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
getsidwas a throwing stub. It now follows FreeBSD'skern_getsid(kern_prot.c) for the only guest process: 0 and its own pid return its session id, any other pid returns -1 withESRCH.The session id is the guest's own pid: the guest is taken to lead its own session, as
killandsetsidalready take it to lead its own process group. This is an assumption, not a console measurement, and is recorded in TechnicalDebt.No open pull request implements
getsid; #4138 only has the neighbouring TechnicalDebt line as context.Tested
Windows 11, MinGW-w64 GCC 15.2.0 (WinLibs r7), full build configuration with
BUILD_TESTING=ON. Built and ranguest_ioctl_getsid,guest_kernel_sysandguest_signals: all three pass. The full test suite was not run and no title or homebrew was run.tools/check_conventions.py --base origin/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code