Skip to content

fix(tools): run overlap encoding tests on Python 3.10 - #4457

Closed
arcwiser wants to merge 1 commit into
boykopovar:mainfrom
arcwiser:fix/pr-overlap-python310-test
Closed

arcwiser wants to merge 1 commit into
boykopovar:mainfrom
arcwiser:fix/pr-overlap-python310-test

Conversation

@arcwiser

Copy link
Copy Markdown
Contributor

What

Allow the overlap encoding regression fixture to mock subprocess._text_encoding on Python versions where that private helper does not exist. Python 3.10 otherwise fails all tests using command_output before exercising the UTF-8 handling they cover.

Tested

  • Windows, Python 3.10.11: python -m unittest tools.tests.test_pr_overlap_encoding (10 passed)
  • Windows: python tools/check_conventions.py --base origin/main
  • Windows: git diff --check origin/main
  • Confirmed no open issue or pull request covers this Python 3.10 test failure

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw; no implementation paths changed
  • No notes, investigation .md files or images added to the repository
  • No third-party code added
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: none
  • AI-assisted: yes

@arcwiser

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #4361. The project overlap checker identified the shared test line after opening; #4361 has broader cross-version coverage and should remain the single implementation. Sorry for the duplication.

@arcwiser arcwiser closed this Oct 12, 2026
@arcwiser
arcwiser deleted the fix/pr-overlap-python310-test branch October 12, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant