Repository navigation
feat(libkernel): implement getsid for calling process - #4578
Merged
Merged
Conversation
9 tasks done
jagrat04
force-pushed
the
feat/libkernel-getsid
branch
from
October 12, 2026 18:58
e8c3ccc to
0cbee6e
Compare
Collaborator
|
Checked getsid against FreeBSD's Added on top of your commit:
Full scoped ctest is green (593 tests); merging once CI is green. |
adriadam10
force-pushed
the
feat/libkernel-getsid
branch
from
October 12, 2026 21:10
0cbee6e to
521ad13
Compare
adriadam10
force-pushed
the
feat/libkernel-getsid
branch
from
October 12, 2026 21:13
521ad13 to
935e7d6
Compare
Collaborator
|
Rebased on current main again: the Scoped ctest is green (140 tests, including |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements getsid (NID gokWod7GAH4) in libkernel. In FreeBSD, getsid returns the session ID of the process (or calling process if pid is 0) and ESRCH (3) for unknown processes. Since AnyPS5 models a single guest process leading its own session, getsid returns the calling process ID for pid 0 or the caller's pid, and fails with ESRCH for any other process ID. Adds unit tests in GuestParentProcess.cpp and updates TechnicalDebt.
Tested
Guest unit tests in core/libs/tests/GuestParentProcess.cpp
Checklist