Repository navigation
feat(libSceLibcInternal): implement fminf required for PPSA99902 startup - #4592
Merged
adriadam10 merged 1 commit intoOct 13, 2026
Conversation
This was referenced Oct 12, 2026
adriadam10
requested changes
Oct 12, 2026
adriadam10
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for tracing the imports for PPSA99902. This PR currently bundles three things, two of which are already open elsewhere:
pathconf(libkernel_sys/Export.cpp,GuestKernelSys.cpp, the TechnicalDebt line) is the same implementation as #3611 / #4503 (#4503 is mergeable). The body says "Depends on: #4503", so drop it from this branch instead of carrying a copy; it will conflict with whichever lands first.sceKernelGetSocSensorTemperature(libkernel/Unimplemented.cpp:18and its TechnicalDebt line) overlaps #4588, which implements it with tests. Drop it here and list #4588 under Depends on if you need it.fminf(libSceLibcInternal/Export.cpp:145) is not in any other open PR andstd::fminmatches the libc semantics. Keep this one, but add a test pinning edge rows (one NaN operand returns the other, both NaN,-0.0vs+0.0, ±inf), registered in ctest.
The branch also conflicts with main; please rebase after removing the two duplicates so the PR is one topic (fminf).
leorossi2005
force-pushed
the
feat/libkernel_libSceLibcInternal_missing_ppsa99902
branch
from
October 12, 2026 21:27
f0a6436 to
02d1dbb
Compare
Contributor
Author
|
@adriadam10 Thank for the suggestions, I've dropped I've also done a rebase to remove conflicts with |
adriadam10
approved these changes
Oct 13, 2026
adriadam10
left a comment
Collaborator
There was a problem hiding this comment.
Checked fminf (NID uVRcM2yFdP4) against aerolib and prosper, built and ran guest_fminf (passes; without the export the test fails to link). Thanks for dropping pathconf and the SoC sensor; merging.
leorossi2005
deleted the
feat/libkernel_libSceLibcInternal_missing_ppsa99902
branch
October 14, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fminfinlibSceLibcInternal(resolving NIDuVRcM2yFdP4).Together with
pathconf(#3611) andsceKernelGetSocSensorTemperature(#4588), this resolves all missing ELF imports blocking Sonic Unleashed Recompiled (PPSA99902) from loading and reaching guest entry.Tested
Windows 11 (x86_64), Sonic Unleashed Recompiled (PPSA99902):
Resolves startup relinker failures:
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)