Repository navigation
fix(libkernel): return errors from pread instead of aborting - #4719
Merged
Merged
Conversation
10 tasks done
10 tasks done
10 tasks done
Contributor
The POSIX pread export threw on a null buffer, a negative offset and any host read failure, so a refused read terminated the process. Return -1 and set the guest errno the same way pwrite and sceKernelPread already do.
Collaborator
|
Rebased onto current |
adriadam10
force-pushed
the
fix/pread-posix-errors
branch
from
October 13, 2026 15:15
e8c27ad to
8f39438
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The POSIX
preadexport threw on a null buffer, a negative offset and any failed host read, which terminates the process. It now returns -1 and sets the guest errno exactly likepwriteandsceKernelPreadon main:EFAULTfor a null buffer with a non-zero length,EINVALfor a negative offset, and the mapped host error otherwise (EBADFfor an invalid or write-only descriptor).PPSA01317 stops on its first boot on Windows when a read from its save folder fails, at:
Tested
Windows 11, MinGW,
guest_file_vectoraddspread/pwritechecks for a null buffer, a negative offset, descriptor 9999 and a write-only descriptor.On main:
With the argument checks skipped, the invalid descriptor check on main stops at:
With this change:
guest_aioandguest_shm_openalso pass.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)