Repository navigation
Conversation
Planet Coaster (PPSA01736) imports sceNpWebApi2PushEventAbortHandle (NID 1OLgvahaSco, confirmed with tools/nid_names.py and aerolib); the import audit in boykopovar#3399 resolves the NID to the throwing stub. No title execution was captured. Push event handles are now kept per library context: CreateHandle registers them, DeleteHandle and Terminate drop them, AbortHandle marks one as aborted and CreateFilter on an aborted handle returns ABORTED. An unknown context returns LIB_CONTEXT_NOT_FOUND and an unknown handle HANDLE_NOT_FOUND. Semantics and codes follow shadPS4 e0a466753a1aacbc8db8253be685bf7ab4d9daae (np_web_api2_internal.cpp abortPushEventHandle, np_web_api2_context.cpp, np_web_api2_push_event.cpp, np_error.h), PS4 and unverified on the PS5. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 2d9c2e4)
Collaborator
|
Closing, for the same reasons as #4375 and #4188 (same commit, closed by @oneandonlydean):
Welcome to reopen with the log line where a title stops at this export on |
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Carries screamm’s offered fix for #4174. Push-event handles are tracked by library context,
sceNpWebApi2PushEventAbortHandlemarks a handle aborted, and later filter creation reportsABORTED. Unknown contexts and handles return the corresponding errors; delete and terminate clear handle state.The implementation commit keeps screamm as its author. The cherry-pick reconciles the test declarations and moves the technical-debt entry into the current component file; no
Codexco-author is added. The PS4-derived behavior and result codes remain unverified on PS5.Tested
guest_np_web_api2_tests, and ranctest -R '^guest_np_web_api2$': passed (1/1).tools/check_conventions.py --base upstream/main: passed.git diff --check: passed.Checklist
main; no other open PR implements the same functions