[SandstromPL]

What

sceSaveDataDirNameSearch and sceSaveDataDirNameSearch2 ignore cond->title_id and always list the running title's own saves. Minecraft Preview (PPSA19639) searches for another title's saves (PPSA17221). #1277 lists this as stop 3: such a search must return 0 hits, and here it returns Preview's own saves instead.

Only the running title's saves are kept, so a search with another title's ID now reports zero hits. A null ID or the running title's ID searches as before. shadPS4 and KytyPS5 also search the given title's own save directory and report zero hits when it does not exist. #713 already noted that the PS5 search did not filter by title ID. The running title's ID is the titleId in param.json (GetAppTitleId_nid_postfix), as for the other param.json lookups. What a console returns for another title's saves is not verified, and the debt entry records it.

Tested

Ubuntu 24.04, GCC 13.3, full build (Release):

• guest_savedata_search gains OtherTitle. With param.json titleId PPSA00000 and one save, both search functions must find:

  • 1 hit with no title ID and 1 with PPSA00000;
  • 0 hits with PPSA17221, with the name buffer left untouched.

  On main it fails with "a search for another title must find none of the running title's saves". It passes here, 5 runs out of 5. All 13 save data tests pass.

• Built at 99e4dfefe. The save data, AppMetadata and libkernel sources are identical on current main; libc differs only in Syslog.cpp (fix(libc): implement openlog and closelog state #5048).

• Minecraft Preview was not run. Minecraft Preview (PPSA19639) #1277's stop 3 comes from its reporter's build. Of the earlier stops, feat(libSceHttp2): complete asynchronous requests through the kqueue option #1092 fixed stop 1, but stop 2 (the NetCtl and NpManager callbacks) is still open on main.

• fix(savedata): report a save's size as the mount that created it gave #5094 changes other lines of dirNameSearch, the same test file and the same debt file; the two merge cleanly.

• tools/check_conventions.py from main passes with this title and body.

Checklist

• Based on current main; no other open PR implements the same functions
• One topic per PR; follow-ups go in a new PR
• No comments in code except technical debt
• Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
• No notes, investigation .md files or images added to the repository (attach them to this PR)
• New third-party code is a submodule built from source
• Generic behaviour, not specific to one title
• Depends on: none
• Unblocks: PPSA19639 Minecraft Preview (PPSA19639) #1277 (stop 3, from the reporter's build; not rerun here)
• GPUs tested: n/a
• AI-assisted: yes (Claude Code); I reviewed and tested every line

🤖 Generated with Claude Code

[xXPBSXx]

Windows test: head d34b78890 merged onto current main 60fb61870, together with 9 other open pull requests in one build (the merges were conflict-free); a failure would have been bisected per PR. Windows 10, MinGW GCC (WinLibs), Ninja Release, -j2: full build 0 errors; ctest for the tests this change adds or touches: guest_savedata_search passed; python tools/check_conventions.py --base upstream/main passed for the combined tree. I did not run the new tests against main without the change.

AI-assisted (Claude Code).

[SandstromPL]

Thanks for the Windows run! For completeness: on Linux the new check fails on main ("a search for another title must find none of the running title's saves") and passes with this change, as listed under Tested.