Repository navigation
fix(tools): audit imports of guest modules - #5171
Closed
likecrank-dotcom wants to merge 1 commit into
Closed
likecrank-dotcom wants to merge 1 commit into
likecrank-dotcom wants to merge 1 commit into
Conversation
AI assistance: OpenAI Codex (AI) implemented and validated this change. The human author remains responsible for review and submission.
Author
|
Closing this PR to avoid duplicating the broader AI-assisted (OpenAI Codex); the human author is responsible for the submitted work. |
This was referenced Oct 13, 2026
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #4202.
When
--modulespoints at title-owned ELF modules, the audit now discovers each module's<executable>.<module>.guest.prx.registry.jsonsidecar beside the executable registry and includes those imports in the same report. A missing sidecar fails with a diagnostic that names the module and tells the user to rerun relinker with--registry. Explicitly supplied sidecars remain supported and are deduplicated. Updated the usage example to show the single-registry command.Tested
Windows native, Python from
D:\anyps5_work\tools\python:python -m unittest discover -s tools/tests -p "test_*.py"— 264 passed, 2 skipped.python tools/check_conventions.py --base origin/main --head HEAD— passed.git diff --check origin/main...HEAD— passed.No title package was available; no title runtime was run.
Checklist
main; no other open PR implements the same functions