Repository navigation
test(agc): cover repeated untracked storage writes after sampling - #5708
adriadam10 merged 3 commits into
Conversation
0262dea to
e89c56d
Compare
|
The overlap is with #5761, whose description explicitly marks it as a combined test build, not for merging. This PR adds only the sample-then-redirty regression; it is distinct from the direct second-store case in #5760. I updated the body to record that distinction and the dependency on #5790 for safe fixture cleanup. |
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
|
Checked the new Added one commit on your branch: Merging once the full Build is green. |
e89c56d to
47cbb99
Compare
|
Rebased onto current Merging once the full Build is green. |
47cbb99 to
d17895e
Compare
What
Adds an execution regression for #5693's repeated unwatched storage-image case. It stores an image, samples the live image into a separate surface, marks the original image dirty again without re-uploading it, then changes guest bytes while the repeated result is pending. The next guest read must preserve the CPU-written bytes.
This case failed at the existing "guest bytes not saved" guard before #5679. That fix is now on
main; the case passes there and guards the behavior. It covers the sample-then-redirty path, distinct from #5760's direct second-store kernel case. The overlap bot also flags #5761, an explicitly test-only combined integration build that is not intended for merging; this PR contains only this regression case.Tested
main(145cb82f3b54d8360e728c3cd7ed82a6fa2eee1a), including fix(agc): save the guest bytes of units without a write generation when results land outside the write watch #5679 and fix(agc): keep the saved guest bytes of units a fill or image copy does not cover #5707.tools/check_conventions.py --base upstream/main --head HEADandgit diff --checkpass.Checklist
main; no other open PR adds this sample-then-redirty regression caseNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository