Repository navigation
feat(libSceWebBrowserDialog): implement sceWebBrowserDialogOpenForPredeterminedContent - #5904
Conversation
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
369e4b7 to
eac580a
Compare
|
@oneandonlydean @adriadam10 Rebased clean on latest origin/main (8dc92ae) with all CI checks passing green. Implements sceWebBrowserDialogOpenForPredeterminedContent for dialog transitions (PPSA17221). Ready for review when convenient, thanks! |
|
A second title that stops on this function: Metal Gear Solid 4 (PPSA18194, Master Collection 01.004.003). Its Unity launcher calls it from the manual cover screen, the one with an "Open Online Manual" button hint. Linux (Ubuntu 24.04, GCC 13.3, Release, RTX 4070 Ti, NVIDIA 595.99), relinked with
So finishing at once with the user-canceled result is enough for this launcher. #6092 makes the same change without the null check. I only ran this PR's head. AI-assisted: yes |
jotitadev
left a comment
There was a problem hiding this comment.
Linux run: head eac580a54 merged onto main 44df21632 (clean merge). Adds a Linux run to the Windows one in the description.
Machine: Ubuntu 26.04, Intel i7-8700, GCC 15.2, full build, non-GPU tests (Release, BUILD_TESTING=ON).
- Build: full build passes.
guest_web_browser_dialog: passes with the PR. With only the test change onmainit aborts with "sceWebBrowserDialogOpenForPredeterminedContent not implemented".- Non-GPU suite (
ctest -E "^agc"): no regressions; the only failures arefile_writer_binaryandfile_writer_text, which fail onmainon this machine too.
Written with AI assistance (Claude Code). I ran the builds and tests above on my machine.
eac580a to
f033be0
Compare
|
@oneandonlydean @adriadam10 Cleanly rebased on latest main (e0e3ced) with all checks passing green. Ready for review/merge when convenient! |
…determinedContent
…ead allow-list argument Co-Authored-By: Claude <noreply@anthropic.com>
|
Re-checked on current Added one commit on top: the technical debt line was cut off mid-sentence and didn't say that the real export takes a second argument (the allow-list of up to twenty addresses, per SharpProspero Merging once CI is green. |
f033be0 to
7f03455
Compare
What
Implements
sceWebBrowserDialogOpenForPredeterminedContentinlibSceWebBrowserDialog.prx:NotImplemented_nid_no_patch(__func__)stub with the common dialog lifecycle transition matchingsceWebBrowserDialogOpen.COMMON_DIALOG_ERROR_NOT_INITIALIZED(0x80B80003) if uninitialized, orCOMMON_DIALOG_ERROR_BUSY(0x80B80007) if already running.COMMON_DIALOG_ERROR_ARG_NULL(0x80B8000D).COMMON_DIALOG_STATUS_FINISHEDand returns 0 (COMMON_DIALOG_OK).GuestWebBrowserDialog.cppto verify uninitialized rejection, null argument rejection, successful state advancement to finished, and user cancelled result reporting.docs/dev/debt/libSceWebBrowserDialog.md.Target context: Minecraft Bedrock (PPSA17221, #5744). The title imports
sceWebBrowserDialogOpenForPredeterminedContentfromlibSceWebBrowserDialog.prx.Tested
GuestWebBrowserDialog.cpptest suite passes with full lifecycle coverage.python tools/check_conventions.py --base origin/mainpasses with 0 findings and 0 errors.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)