Repository navigation
fix(pad): read controller commands from Unicode paths - #5970
Merged
adriadam10 merged 1 commit intoOct 16, 2026
Merged
Conversation
11 tasks done
Collaborator
|
Checked the diff, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Controller pulses through
APS5_PAD_INPUT_FILEnever arrive on Windows when the command file's path contains characters outside the host code page. The environment variable and file reader both use narrow strings, so a path such asžluťoučký-漢字loses its filename before the file is opened.Read the Windows environment variable with
_wgetenvand retain a nativestd::filesystem::pathin the existing command reader. POSIX paths still use their native bytes. The regression uses a Unicode filename for the existing end-to-end button and stick injection checks, including expiry and restoration of physical input. Existing ASCII command parsing and disabled-input checks remain covered.Tested
I tested on Windows 11 Pro, MinGW-w64 GCC 15.2.0 (WinLibs), Release/Ninja, with
BUILD_TESTING=ON.main5ef619a914b10befdb6371904b46b23701aa3c62,guest_padaborts after the command fails to arrive (2.67 s), also outside the sandbox.maine154f5658,guest_pad,pad_input_mappingandpad_keyboard_mousepass (3/3, 1.38 s).python tools/check_conventions.py --base origin/mainpass;git diff --checkpasses.Linux/macOS and a retail title were not run. This fixes the documented local controller command workflow.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in technical debt.mdfiles or images added to the repository