Repository navigation
test(agc): treat an unopenable /dev/udmabuf as no dma-buf imports in the recorder - #6038
Closed
oneandonlydean wants to merge 1 commit into
Closed
oneandonlydean wants to merge 1 commit into
oneandonlydean wants to merge 1 commit into
Conversation
…the recorder The recorder only checked that /dev/udmabuf exists. On a runner where it exists but cannot be opened read-write, dmaBufImport stayed on and the dma-buf import probe failed at open /dev/udmabuf, although the device copies those ranges instead. Open the device the way the imports do.
This was referenced Oct 15, 2026
Merged
This was referenced Oct 15, 2026
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This was referenced Oct 15, 2026
Closed
Collaborator
|
Closing as obsolete: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the Linux CI failure of
agc_driver_recorderonmainand on unrelated PRs (for example run 38622749700 onmain):#5211 registered the full recorder run with CTest, so CI now runs it. Its test device turns
dmaBufImportoff only when/dev/udmabufdoes not exist. On the CI runner the device exists but cannot be opened read-write, sodmaBufImportstays on andimportWatchTestsruns the dma-buf import probe, which fails atopen /dev/udmabuf. The emulator handles the same case by copying those ranges (udmabufDevice()inGuestBufferMemory.cpp).The test device now opens
/dev/udmabufwithO_RDWR | O_CLOEXEC, the same flags the imports use, and turnsdmaBufImportoff when that fails.Tested
Linux (CachyOS, GCC 16.2.1), Release,
BUILD_TESTING=ON,ctest -R "agc_driver_recorder|udmabuf|import"(20 tests). "No access" meansopen("/dev/udmabuf")is made to fail withEACCESthrough anLD_PRELOADshim.agc_driver_recorderfails with the CI errorChecklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)