Skip to content

feat(libSceNet): add sceNetEtherStrton - #6250

Closed
YousefMohsen0 wants to merge 1 commit into
boykopovar:mainfrom
YousefMohsen0:feat/libSceNet-ether-strton
Closed

YousefMohsen0 wants to merge 1 commit into
boykopovar:mainfrom
YousefMohsen0:feat/libSceNet-ether-strton

Conversation

@YousefMohsen0

Copy link
Copy Markdown

What

Adds sceNetEtherStrton to libSceNet: parses xx:xx:xx:xx:xx:xx (hex, either case) into a 6-byte address, the inverse of sceNetEtherNtostr. Other text and null arguments fail with EINVAL and leave the output unchanged. Signature and accepted forms are unverified on hardware; recorded in docs/dev/debt/libSceNet.md.

Tested

Not tested on a title or homebrew; no title ID or halt log line to report. g++ -std=c++20 -Wall -Wextra: no warnings. Linux x86-64 harness against the compiled Export.cpp: valid parse, round-trip with sceNetEtherNtostr, 10 malformed inputs and 2 null arguments. python3 tools/check_conventions.py --base upstream/main passes. Full build and ctest not run.

Checklist

  • Based on current main; no other open PR implements the same functions (verify)
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes

🤖 Generated with Claude Code

Parses the colon-separated hexadecimal form sceNetEtherNtostr writes
into a 6-byte address. Other text and null arguments fail with EINVAL
and leave the output unchanged. Behaviour for other accepted forms is
unverified on hardware and recorded in the libSceNet technical debt.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Ln7PRo6yA9pniHMcNCQ3g
Copilot AI balanced review requested due to automatic review settings October 15, 2026 07:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
PR 5836 docs/dev/debt/libSceNet.md L10
PR 6494 docs/dev/debt/libSceNet.md L10

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 6447 core/libs/prx/libSceNet/Export.cpp
docs/dev/debt/libSceNet.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants