Repository navigation
fix(agc): preserve position export layout on undecodable tail - #6375
Merged
adriadam10 merged 1 commit intoOct 18, 2026
Merged
Conversation
This was referenced Oct 15, 2026
|
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PositionExportLayoutremoves the guest'sPA_CL_VS_OUT_CNTLposition export bits only when decoding proves they are unused. When optional inspection reaches an unimplemented opcode in a padded program tail, it keeps those bits. Other decoder errors still propagate, and shader compilation is unchanged.Add a regression case for the undecodable tail alongside the existing position export checks. Found during My First Gran Turismo (PPSA24156) bring-up. This change does not make the game playable.
Tested
agc_driver_vertex_clip_cull_draw_testson a branch based on currentmain.ctest --test-dir build --output-on-failure -R '^agc_driver_vertex_clip_cull_draw': 2/2 passed, including the no-key variant.python3 tools/check_conventions.py --base origin/main: passed.Checklist
main; no other open PR implements the same functions.mdfiles or images added to the repository