Skip to content

fix: exclude test export aliases from import audit classification - #6769

Merged
oneandonlydean merged 1 commit into
boykopovar:mainfrom
MrMha:fix/audit-test-aliases-20261016
Oct 17, 2026
Merged

oneandonlydean merged 1 commit into
boykopovar:mainfrom
MrMha:fix/audit-test-aliases-20261016

Conversation

@MrMha

@MrMha MrMha commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

What

Collect import-audit export aliases from the same production sources that the progress scanner uses. An alias in a test fixture must not replace a production NID and make a throwing export appear implemented. Preserve the boolean weak-flag regression and other audit changes now on main.

Tested

macOS 27.0.1 arm64, based on main 47a266cf975f00f7fba94013467d03bfa5e355e9. 99 import-audit tests pass on Python 3.12.14 (one existing platform skip); the new regression also passes on Python 3.9.6. The regression fails with unchanged main's production code. Compared #6171 and #6239: they change module identities and direct-import resolution, respectively, and do not implement this source filter. Their unresolved base conflicts prevent a complete merge comparison; neither is a dependency of this fix.

Trusted main conventions checker and whitespace checks pass. No GPU behavior changes.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw; silent stubs are documented where required
  • No notes, investigation .md files or images added to the repository
  • New third-party code is a submodule built from source (none added)
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: none
  • GPUs tested: n/a
  • AI-assisted: yes (OpenAI Codex)

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.

Pull request Shared files not compared
PR 6171 tools/import_audit.py
tools/tests/test_import_audit.py

@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 17, 2026
@MrMha
MrMha force-pushed the fix/audit-test-aliases-20261016 branch from 42a3acf to 8eecd50 Compare October 17, 2026 14:01
@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 17, 2026
@oneandonlydean oneandonlydean self-assigned this Oct 17, 2026
@oneandonlydean
oneandonlydean merged commit a8581d3 into boykopovar:main Oct 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants